Add versionIdentifier and initial Digital Service OMAS APIs #6986

mandy-chessell · 2022-10-09T10:35:33Z

Description

Some initial APIs for Digital Service OMAS are included
A new property for Asset called versionIdentifier was added to the open metadata types and the beans for it were updated to support it.

Related Issue(s)

#6526

Testing

FVT and open metadata labs

Release Notes & Documentation

New attribute has been added to the egeria-docs site both in the open metadata types description and the release notes.

Additional notes

Signed-off-by: Mandy Chessell <[email protected]>

...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/FilesAndFoldersHandler.java

+                assetExtendedProperties = new HashMap<>();
+            }
+
+            assetExtendedProperties.put(OpenMetadataAPIMapper.FILE_NAME_PROPERTY_NAME, this.getFileName(fullPath));


...org/odpi/openmetadata/accessservices/digitalservice/metadataelements/SubjectAreaElement.java

+     *
+     * @param elementHeader element header object
+     */
+    public void setElementHeader(ElementHeader elementHeader)


...org/odpi/openmetadata/accessservices/digitalservice/metadataelements/SubjectAreaElement.java

+     *
+     * @return element header object
+     */
+    public ElementHeader getElementHeader()


...src/main/java/org/odpi/openmetadata/accessservices/assetowner/properties/FileProperties.java

+                       ", owner='" + getOwner() + '\'' +
+                       ", ownerTypeName='" + getOwnerTypeName() + '\'' +
+                       ", ownerPropertyName='" + getOwnerPropertyName() + '\'' +
+                       ", ownerType=" + getOwnerType() +


sonatype-lift · 2022-10-09T12:34:13Z

...enmetadata/accessservices/stewardshipaction/outtopic/StewardshipActionOMRSTopicListener.java

+                return true;
+            }
+
+            return (typeNames.contains(OpenMetadataAPIMapper.INCIDENT_REPORT_TYPE_NAME));


UnnecessaryParentheses: These grouping parentheses are unnecessary; it is unlikely the code will be misinterpreted without them

Suggested change

return (typeNames.contains(OpenMetadataAPIMapper.INCIDENT_REPORT_TYPE_NAME));

return typeNames.contains(OpenMetadataAPIMapper.INCIDENT_REPORT_TYPE_NAME);

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-09T12:34:14Z

...etadata/adapters/connectors/integration/basicfiles/DataFilesMonitorIntegrationConnector.java

                                {
-                                    File file = new File(dataFile.getDataFileProperties().getQualifiedName());
+                                    File file = new File(dataFile.getDataFileProperties().getPathName());


PATH_TRAVERSAL_IN: This API (java/io/File.(Ljava/lang/String;)V) reads a file whose location might be specified by user input

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-09T12:34:16Z

...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/FilesAndFoldersHandler.java

+                assetExtendedProperties = new HashMap<>();
+            }
+
+            assetExtendedProperties.put(OpenMetadataAPIMapper.FILE_NAME_PROPERTY_NAME, this.getFileName(fullPath));


NULL_DEREFERENCE: object assetExtendedProperties last assigned on line 2531 could be null and is dereferenced at line 2548.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-09T12:34:17Z

...enmetadata/accessservices/stewardshipaction/outtopic/StewardshipActionOMRSTopicListener.java

        {
            List<String> typeNames = new ArrayList<>();

-            typeNames.add(entityHeader.getType().getTypeDefName());
+            typeNames.add(instanceHeader.getType().getTypeDefName());


NULL_DEREFERENCE: object returned by instanceHeader.getType() could be null and is dereferenced at line 838.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-09T12:34:18Z

...in/java/org/odpi/openmetadata/accessservices/datamanager/properties/DataStoreProperties.java

+        {
+            return false;
+        }
+        if (modifiedTime != null ? ! modifiedTime.equals(that.modifiedTime) : that.modifiedTime != null)


💬 5 similar findings have been found in this PR

JavaUtilDate: Date has a bad API that leads to bugs; prefer java.time.Instant or LocalDate.

🔎 Expand here to view all instances of this finding

File Path Line Number

open-metadata-implementation/access-services/data-manager/data-manager-api/src/main/java/org/odpi/openmetadata/accessservices/datamanager/properties/DataStoreProperties.java 308

open-metadata-implementation/access-services/data-manager/data-manager-api/src/main/java/org/odpi/openmetadata/accessservices/datamanager/properties/ReportProperties.java 265

open-metadata-implementation/access-services/data-manager/data-manager-api/src/main/java/org/odpi/openmetadata/accessservices/datamanager/properties/ReportProperties.java 261

open-metadata-implementation/access-services/community-profile/community-profile-api/src/main/java/org/odpi/openmetadata/accessservices/communityprofile/properties/AssetProperties.java 246

open-metadata-implementation/access-services/community-profile/community-profile-api/src/main/java/org/odpi/openmetadata/accessservices/communityprofile/properties/AssetProperties.java 250

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-09T12:34:20Z

...in/java/org/odpi/openmetadata/accessservices/datamanager/properties/DataStoreProperties.java

+        {
+            return false;
+        }
+        if (createTime != null ? ! createTime.equals(that.createTime) : that.createTime != null)


💬 11 similar findings have been found in this PR

UndefinedEquals: Date does not have well-defined equals behavior.

🔎 Expand here to view all instances of this finding

File Path Line Number

open-metadata-implementation/access-services/data-manager/data-manager-api/src/main/java/org/odpi/openmetadata/accessservices/datamanager/properties/ReportProperties.java 265

open-metadata-implementation/access-services/community-profile/community-profile-api/src/main/java/org/odpi/openmetadata/accessservices/communityprofile/properties/AssetProperties.java 250

open-metadata-implementation/access-services/community-profile/community-profile-api/src/main/java/org/odpi/openmetadata/accessservices/communityprofile/properties/AssetProperties.java 246

open-metadata-implementation/access-services/stewardship-action/stewardship-action-api/src/main/java/org/odpi/openmetadata/accessservices/stewardshipaction/properties/ClassificationProperties.java 175

open-metadata-implementation/access-services/stewardship-action/stewardship-action-api/src/main/java/org/odpi/openmetadata/accessservices/stewardshipaction/properties/ReferenceableProperties.java 274

open-metadata-implementation/access-services/stewardship-action/stewardship-action-api/src/main/java/org/odpi/openmetadata/accessservices/stewardshipaction/properties/ClassificationProperties.java 174

open-metadata-implementation/access-services/stewardship-action/stewardship-action-api/src/main/java/org/odpi/openmetadata/accessservices/stewardshipaction/properties/ReferenceableProperties.java 275

open-metadata-implementation/access-services/stewardship-action/stewardship-action-api/src/main/java/org/odpi/openmetadata/accessservices/stewardshipaction/properties/RelationshipProperties.java 176

open-metadata-implementation/access-services/data-manager/data-manager-api/src/main/java/org/odpi/openmetadata/accessservices/datamanager/properties/ReportProperties.java 261

open-metadata-implementation/access-services/stewardship-action/stewardship-action-api/src/main/java/org/odpi/openmetadata/accessservices/stewardshipaction/properties/RelationshipProperties.java 175

Showing 10 of 11 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-09T12:34:23Z

⚠️ 107 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

mandy-chessell added 2 commits October 9, 2022 11:30

Add versionIdentifier

65caf51

Signed-off-by: Mandy Chessell <[email protected]>

Initial API for Data Products

a560c94

Signed-off-by: Mandy Chessell <[email protected]>

mandy-chessell requested review from planetf1, popa-raluca and lcpopa as code owners October 9, 2022 10:35

mandy-chessell added 3 commits October 9, 2022 11:36

Add Digital Service OMAS client

ed854e7

Signed-off-by: Mandy Chessell <[email protected]>

Add Digital Service OMAS client

90b1c29

Signed-off-by: Mandy Chessell <[email protected]>

Merge branch 'master' of https://github.com/odpi/egeria into egeria-code

455f522

mandy-chessell enabled auto-merge October 9, 2022 10:38

github-advanced-security bot found potential problems Oct 9, 2022

View reviewed changes

mandy-chessell merged commit a6beb7d into odpi:master Oct 9, 2022

sonatype-lift bot reviewed Oct 9, 2022

View reviewed changes

planetf1 mentioned this pull request Nov 2, 2022

Release 3.13 #6988

Closed

31 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add versionIdentifier and initial Digital Service OMAS APIs #6986

Add versionIdentifier and initial Digital Service OMAS APIs #6986

mandy-chessell commented Oct 9, 2022

sonatype-lift bot Oct 9, 2022

sonatype-lift bot Oct 9, 2022

sonatype-lift bot Oct 9, 2022

sonatype-lift bot Oct 9, 2022

sonatype-lift bot Oct 9, 2022

sonatype-lift bot Oct 9, 2022

sonatype-lift bot commented Oct 9, 2022

	return (typeNames.contains(OpenMetadataAPIMapper.INCIDENT_REPORT_TYPE_NAME));
	return typeNames.contains(OpenMetadataAPIMapper.INCIDENT_REPORT_TYPE_NAME);

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

File Path	Line Number
open-metadata-implementation/access-services/data-manager/data-manager-api/src/main/java/org/odpi/openmetadata/accessservices/datamanager/properties/DataStoreProperties.java	308
open-metadata-implementation/access-services/data-manager/data-manager-api/src/main/java/org/odpi/openmetadata/accessservices/datamanager/properties/ReportProperties.java	265
open-metadata-implementation/access-services/data-manager/data-manager-api/src/main/java/org/odpi/openmetadata/accessservices/datamanager/properties/ReportProperties.java	261
open-metadata-implementation/access-services/community-profile/community-profile-api/src/main/java/org/odpi/openmetadata/accessservices/communityprofile/properties/AssetProperties.java	246
open-metadata-implementation/access-services/community-profile/community-profile-api/src/main/java/org/odpi/openmetadata/accessservices/communityprofile/properties/AssetProperties.java	250

Add versionIdentifier and initial Digital Service OMAS APIs #6986

Add versionIdentifier and initial Digital Service OMAS APIs #6986

Conversation

mandy-chessell commented Oct 9, 2022

Description

Related Issue(s)

Testing

Release Notes & Documentation

Additional notes

sonatype-lift bot Oct 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 9, 2022

Choose a reason for hiding this comment

sonatype-lift bot commented Oct 9, 2022