Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch SubjectArea OMAS REST logging to use RESTCallLogger instead of Logger #7049

Merged
merged 5 commits into from
Nov 11, 2022

Conversation

Raunak-S
Copy link
Contributor

Description

This pull request does the following:

  1. Changes occurrences of Logger.debug to a combination of RESTCallLogger.logRESTCall and RESTCallLogger.logRESTCallReturn
  2. Removes old Logger instantiations
  3. Removes old success Logger call from the SubjectAreaProjectHandler since it is already logged in the SubjectAreaProjectRESTServices

Related Issue(s)

Associated issue is #7001 and is used to track changes to the Subject Area OMAS for a larger umbrella issue.

Testing

Ran complete Egeria unit tests and FVTs using mvn clean verify on local machine .

Release Notes & Documentation

PR does not change any core functionality of how the Subject Area OMAS works, so no documentation changes needed. If there are spots to change in the docs that I missed, please let me know and I can make those changes.

Additional notes

N/A

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Oct 21, 2022

⚠️ 110 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@Raunak-S Raunak-S marked this pull request as ready for review November 4, 2022 16:57
@Raunak-S
Copy link
Contributor Author

Raunak-S commented Nov 7, 2022

@davidradl changed PR from draft to ready for review. Feel free to take a look at your earliest convenience, thanks!

@davidradl davidradl merged commit ace7188 into odpi:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants