-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the content of connector types (#7103) #7106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...data/engineservices/repositorygovernance/connector/RepositoryGovernanceServiceConnector.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/frameworks/governanceaction/GeneralGovernanceActionService.java
Show resolved
Hide resolved
...work/src/main/java/org/odpi/openmetadata/frameworks/auditlog/AuditLogReportingComponent.java
Show resolved
Hide resolved
...amework/src/main/java/org/odpi/openmetadata/frameworks/connectors/ConnectorProviderBase.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/frameworks/governanceaction/GeneralGovernanceActionService.java
Show resolved
Hide resolved
...s/src/main/java/org/odpi/openmetadata/repositoryservices/auditlog/OMRSAuditingComponent.java
Show resolved
Hide resolved
...adata/repositoryservices/connectors/stores/auditlogstore/OMRSAuditLogReportingComponent.java
Show resolved
Hide resolved
@@ -122,7 +122,7 @@ | |||
this.governanceContext = context; | |||
this.governanceActionService = service; | |||
|
|||
if (governanceActionServiceConnector instanceof GovernanceActionService) | |||
if (governanceActionServiceConnector instanceof GeneralGovernanceActionService) |
Check notice
Code scanning / CodeQL
Chain of 'instanceof' tests
This if block performs a chain of 6 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.
...n/java/org/odpi/openmetadata/frameworks/governanceaction/GeneralGovernanceActionService.java
Show resolved
Hide resolved
...data/engineservices/repositorygovernance/connector/RepositoryGovernanceServiceConnector.java
Show resolved
Hide resolved
...data/engineservices/repositorygovernance/connector/RepositoryGovernanceServiceConnector.java
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/frameworks/governanceaction/GeneralGovernanceActionService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mandy Chessell [email protected]
Description
This PR improves the information captures in a connector provider's connector type:
Here is an example of a connector type from an integration connector:
Notice the new marker interface
FilesIntegratorOMISConnector
.Here is an example from a governance action service:
Notice marker interface
GovernanceActionService
.Finally, I uncovered a bug in the templating - the new entity was unsing the caller type information, not that from the template entity - this meant that it was being created with a more generic type and some of the properties from the template could be invalid.
Related Issue(s)
#7103
Testing
Using the new Governance Server Lab.
Release Notes & Documentation
No more than needed for the original feature
Additional notes