#7147 Update schema attribute in asset manager , changed to ensure that dataType is updated #7221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
mandy-chessell
requested changes
Dec 2, 2022
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/accessservices/assetmanager/handlers/SchemaExchangeHandler.java
Outdated
Show resolved
Hide resolved
...n/java/org/odpi/openmetadata/accessservices/assetmanager/handlers/SchemaExchangeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Show resolved
Hide resolved
Signed-off-by: David Radley <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Fixed
Show fixed
Hide fixed
Signed-off-by: David Radley <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Show resolved
Hide resolved
mandy-chessell
previously requested changes
Dec 4, 2022
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Show resolved
Hide resolved
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
...n/java/org/odpi/openmetadata/accessservices/assetmanager/handlers/SchemaExchangeHandler.java
Fixed
Show fixed
Hide fixed
...n/java/org/odpi/openmetadata/accessservices/assetmanager/handlers/SchemaExchangeHandler.java
Fixed
Show fixed
Hide fixed
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
davidradl
dismissed
mandy-chessell’s stale review
it is out of date and I have addressed the concerns raised.
Signed-off-by: David Radley <[email protected]>
|
@mandy-chessell I have just added code to remove the calculated value classification for a non merge update without a formula. I have tested this using the sample lineage connector. It would be great if you could review please. |
Signed-off-by: David Radley <[email protected]>
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Radley <[email protected]>
|
@mandy-chessell I am hoping to merge at the end of Thursday (8th of December). Please let me know if you need more time to review. |
...n/java/org/odpi/openmetadata/accessservices/assetmanager/handlers/SchemaExchangeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Show resolved
Hide resolved
...rs/src/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaTypeBuilder.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Show resolved
Hide resolved
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
...rs/src/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaTypeBuilder.java
Outdated
Show resolved
Hide resolved
...rs/src/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaTypeBuilder.java
Show resolved
Hide resolved
...c/main/java/org/odpi/openmetadata/commonservices/generichandlers/SchemaAttributeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Signed-off-by: David Radley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
asset manager omas schema processing has been changed to pass the datatype down.
Related Issue(s)
Testing
I have tested this with the lineage sample integration connector
Release Notes & Documentation
Additional notes