git7234 increase scope for unique properties check #7237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Radley <[email protected]>
|
@lpalashevski here is the pr for #7234 - you expressed some interest in it. |
...java/org/odpi/openmetadata/commonservices/generichandlers/OpenMetadataAPIGenericHandler.java
Outdated
Show resolved
Hide resolved
mandy-chessell
approved these changes
Dec 8, 2022
Signed-off-by: David Radley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Radley [email protected]
The generic handler code that checks for uniqueness for unique attributes has been changed to check at the level of the type where the unique attribute is defined , rather than the type in the entity that was supplied.
Description
The generic handler code that checks for uniqueness for unique attributes has been changed to check at the level of the type where the unique attribute is defined , rather than the type in the entity that was supplied.
The code starts with the type supplied in the entity and looks for the unique property in it, it checks the super types until it finds th property, then looks for existing entities using that type.
Related Issue(s)
Testing
I have tested by creating a glossary through the subject area omas with a qualified name then created an asset with the same qualified name, this fails.
Release Notes & Documentation
Yes this is important as this could effect existing use cases.
Additional notes
This effects create and update.