Asset Catalog exact-match filter fix #7241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liviu Constantin Popa <[email protected]>
lcpopa
requested review from
mandy-chessell and
alexandra-bucur
as code owners
davidradl
reviewed
Dec 12, 2022
...java/org/odpi/openmetadata/commonservices/generichandlers/OpenMetadataAPIGenericHandler.java
Show resolved
Hide resolved
davidradl
reviewed
Dec 12, 2022
...ain/java/org/odpi/openmetadata/accessservices/assetcatalog/handlers/AssetCatalogHandler.java
Show resolved
Hide resolved
lpalashevski
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Liviu Constantin Popa [email protected]
Search from asset-catalog omas was producing erroneous results when ticking exactMatch option
Description
The reason for the erroneous result was the search string being regExed twice: once in the asset catalog code and once in the generic handler, when the exactMatch option is set to true. When it reached the graph repository it was no longer recognizable to allow entity extraction.
The solution that seem to fit best is to remove the search string decoration (regEx) in asset catalog and improve the one in generic handler to include the caseInsesitive flag, since their behaviour is intertwined. This meant the method signature needed the extra caseInsensitive param. Also, all calls to the method in generic handler are updated with the caseInsensitive flag defaulted to the value from the original behaviour, so there are no changes in expected outcome when called from other places
Related Issue(s)
None found
Testing
Manual
Release Notes & Documentation
None
Additional notes
None