Create Jackson object mapper, readers and writers at class level #7251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandra Bucur <[email protected]>
alexandra-bucur
requested review from
planetf1,
davidradl,
mandy-chessell,
pmarius22,
popa-raluca,
lpalashevski,
lcpopa and
cmgrote
as code owners
alexandra-bucur
changed the title
Signed-off-by: Alexandra Bucur <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
...i/openmetadata/accessservices/analyticsmodeling/fvt/synchronization/SynchronizationTest.java
Outdated
Show resolved
Hide resolved
...i/openmetadata/accessservices/analyticsmodeling/fvt/synchronization/SynchronizationTest.java
Outdated
Show resolved
Hide resolved
popa-raluca
approved these changes
Dec 19, 2022
davidradl
reviewed
Dec 19, 2022
...rc/main/java/org/odpi/openmetadata/conformance/client/OpenMetadataConformanceTestReport.java
Show resolved
Hide resolved
davidradl
reviewed
Dec 19, 2022
...ters/repositoryservices/graphrepository/repositoryconnector/GraphOMRSRelationshipMapper.java
Show resolved
Hide resolved
Signed-off-by: Alexandra Bucur <[email protected]> Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
Signed-off-by: Alexandra Bucur <[email protected]>
Signed-off-by: Alexandra Bucur <[email protected]>
alexandra-bucur
force-pushed
the
object-mappers
branch
from
4dc20d9
to
8ecd1f7
Compare
lpalashevski
approved these changes
Dec 19, 2022
...ain/java/org/odpi/openmetadata/accessservices/subjectarea/outtopic/SubjectAreaPublisher.java
Show resolved
Hide resolved
...i/openmetadata/accessservices/analyticsmodeling/fvt/synchronization/SynchronizationTest.java
Show resolved
Hide resolved
added 4 commits
December 20, 2022 15:24
Signed-off-by: Alexandra Bucur <[email protected]>
Signed-off-by: Alexandra Bucur <[email protected]>
|
Let's wait before we merge this; we may need to first merge #7138 then resolve small conflicts in this one. |
� Conflicts: � open-metadata-implementation/access-services/asset-consumer/asset-consumer-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/assetconsumer/connectors/outtopic/AssetConsumerOutTopicServerConnector.java � open-metadata-implementation/access-services/asset-manager/asset-manager-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/assetmanager/connectors/outtopic/AssetManagerOutTopicServerConnector.java � open-metadata-implementation/access-services/asset-owner/asset-owner-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/assetowner/connectors/outtopic/AssetOwnerOutTopicServerConnector.java � open-metadata-implementation/access-services/community-profile/community-profile-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/communityprofile/connectors/outtopic/CommunityProfileOutTopicServerConnector.java � open-metadata-implementation/access-services/data-engine/data-engine-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/dataengine/connectors/intopic/DataEngineInTopicClientConnector.java � open-metadata-implementation/access-services/data-manager/data-manager-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/datamanager/connectors/outtopic/DataManagerOutTopicServerConnector.java � open-metadata-implementation/access-services/digital-architecture/digital-architecture-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/digitalarchitecture/connectors/outtopic/DigitalArchitectureOutTopicServerConnector.java � open-metadata-implementation/access-services/governance-engine/governance-engine-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/governanceengine/connectors/outtopic/GovernanceEngineOutTopicServerConnector.java � open-metadata-implementation/access-services/it-infrastructure/it-infrastructure-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/itinfrastructure/connectors/outtopic/ITInfrastructureOutTopicServerConnector.java � open-metadata-implementation/access-services/security-manager/security-manager-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/securitymanager/connectors/outtopic/SecurityManagerOutTopicServerConnector.java � open-metadata-implementation/access-services/security-officer/security-officer-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/securityofficer/connectors/outtopic/SecurityOfficerOutTopicServerConnector.java � open-metadata-implementation/access-services/stewardship-action/stewardship-action-topic-connectors/src/main/java/org/odpi/openmetadata/accessservices/stewardshipaction/connectors/outtopic/StewardshipActionOutTopicServerConnector.java � open-metadata-implementation/repository-services/repository-services-apis/src/main/java/org/odpi/openmetadata/repositoryservices/connectors/omrstopic/OMRSTopicConnector.java
lpalashevski
approved these changes
Jan 25, 2023
...n/java/org/odpi/openmetadata/repositoryservices/connectors/omrstopic/OMRSTopicConnector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandra Bucur <[email protected]>
...a/adapters/repositoryservices/graphrepository/repositoryconnector/GraphOMRSEntityMapper.java
Show resolved
Hide resolved
...rs/repositoryservices/graphrepository/repositoryconnector/GraphOMRSClassificationMapper.java
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/odpi/egeria/7251.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/odpi/egeria/7251.diff | git applyOnce you're satisfied commit and push your changes in your project. Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to improve performance overall, I removed all object mappers creation inside methods and instantiate the object at class level as a static final member.