Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename split packages (#7246) #7307

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

mandy-chessell
Copy link
Contributor

Signed-off-by: Mandy Chessell [email protected]

Description

As described by @planetf1 in issue #7246, it is not good practice to have java classes from different modules contribute to the same Java package. This PR renames classes and packages in order to ensure java packages sit within one module.

The changes to the java classes also required updates in consuming code - hence the large number of changed files.

Related Issue(s)

#7246

Testing

Build, UT, FVT

Release Notes & Documentation

Purely internal

Additional notes

This fix is to enable the use of Java modules in release 4.0.

@planetf1
Copy link
Member

planetf1 commented Jan 4, 2023

Thanks for doing the change. I've not validated this captures all the conflicts - hopefully, based on the original issue description.

The current module 'poc' is up to date with main as of today (including framework change) but I think this is harder to merge as there'll be a lot of conflicts from both my renames (which were only ever a test to help get things working to understand the impact) as well as the two large commits here.

I think the next step is probably to discuss whether we are going ahead with module support at our f2f. I can show the poc, and we can make a decision (the module-info files can easily be removed). I'll then figure the best way to merge/rebuild the module info files - probably on top of the regular 4.0 base (which is also up to date)

@mandy-chessell mandy-chessell merged commit b819161 into odpi:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants