Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supplementary properties #7317

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Conversation

mandy-chessell
Copy link
Contributor

Signed-off-by: Mandy Chessell [email protected]

Description

Add support for Supplementary Properties to Asset Consumer OMAS, Asset Owner OMAS and the Open Connector framework Connecyed Asset Services

Related Issue(s)

None

Testing

New FVTs to show the use of these new fields and show

Release Notes & Documentation

Updates have already bee done.

Additional notes

There is a small change to the Jupyter notebooks to display the new values whe nan asset is retrieved.

Signed-off-by: Mandy Chessell <[email protected]>
@@ -73,9 +73,11 @@

bean.setQualifiedName(this.removeQualifiedName(instanceProperties));
bean.setAdditionalProperties(this.removeAdditionalProperties(instanceProperties));
bean.setName(this.removeName(instanceProperties));
bean.setResourceName(this.removeName(instanceProperties));
bean.setName(bean.getResourceName());

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Asset.setName](1) should be avoided because it has been deprecated.
bean.setVersionIdentifier(this.removeVersionIdentifier(instanceProperties));
bean.setDescription(this.removeDescription(instanceProperties));
bean.setResourceDescription(this.removeDescription(instanceProperties));
bean.setDescription(bean.getResourceDescription());

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Asset.setDescription](1) should be avoided because it has been deprecated.
@@ -99,9 +100,11 @@

bean.setQualifiedName(this.removeQualifiedName(instanceProperties));
bean.setAdditionalProperties(this.removeAdditionalProperties(instanceProperties));
bean.setName(this.removeName(instanceProperties));
bean.setResourceName(this.removeName(instanceProperties));
bean.setName(bean.getResourceName());

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Asset.setName](1) should be avoided because it has been deprecated.
bean.setVersionIdentifier(this.removeVersionIdentifier(instanceProperties));
bean.setDescription(this.removeDescription(instanceProperties));
bean.setResourceDescription(this.removeDescription(instanceProperties));
bean.setDescription(bean.getResourceDescription());

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Asset.setDescription](1) should be avoided because it has been deprecated.
owner = template.getOwner();
ownerTypeName = template.getOwnerTypeName();
ownerPropertyName = template.getOwnerPropertyName();
ownerType = template.getOwnerType();
zoneMembership = template.getZoneMembership();
origin = template.getAssetOrigin();
isReferenceData = template.isReferenceData();

description = template.getDescription();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Asset.getDescription](1) should be avoided because it has been deprecated.
owner = template.getOwner();
ownerTypeName = template.getOwnerTypeName();
ownerPropertyName = template.getOwnerPropertyName();
ownerType = template.getOwnerType();
zoneMembership = template.getZoneMembership();
origin = template.getAssetOrigin();
isReferenceData = template.isReferenceData();

description = template.getDescription();
name = template.getName();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Asset.getName](1) should be avoided because it has been deprecated.
@@ -102,6 +109,7 @@

AssetOwner client = thisTest.getAssetOwnerClient(serverName, serverPlatformRootURL, auditLog);
String assetGUID = thisTest.getAsset(client, userId);
String fullAssetGUID = thisTest.getFullAsset(client, userId);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String fullAssetGUID' is never read.
@mandy-chessell mandy-chessell merged commit c31a2b1 into odpi:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant