Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tink version to 1.7 #7393

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

Shrinivas-Kane
Copy link

Bumps tink from 1.6.1 to 1.7.0.

#6828

@Shrinivas-Kane Shrinivas-Kane changed the title signed-off-by: Shrinivas Kane <[email protected]> Bump think version t… Bump think version to 1.7 Feb 1, 2023
@davidradl
Copy link
Member

@planetf1 I assume this pr is not the way we were thinking of doing this, as you are looking to create a new branch 3.10.1 to put this change into. @Shrinivas-Kane can you consume a 3.10.1 ?

@planetf1
Copy link
Member

planetf1 commented Feb 2, 2023

@davidradl It is. I will merge this PR into the 3.10 branch. The reason for having branches is to allow us to easily provide service if the need arises. He's an example. We don't need parallel branches under 3.10 as it will be a single stream. When we create the release 3.10.1, we will tag that particular code level so that it can still become a release in github, as well as ship the maven artifacts and container.

In some of our repositories (for example egeria-charts, and egeria-connector-jdbc) we aren't currently even branching for releases as the community working on each is much smaller, and we've opted to keep with a linear code stream. That may change if needed, and we can still create a branch based upon any commit whenever we wish.

We will increase the 'incremental version'. So the maven artifacts will be like egera-3.10.1

If an attempt is made to get '3.10' ie expressed as a dependency, maven should get 3.10.1 as it's the latest. If you want to be sure to get 3.10.1, you can specify that, or use range patterns to be more precise.

An extension of this can add a build number, so it's possible to really specific (whilst also allowing more general consumption), but I think that's unnecessary for the project and I see it rarely used for open source components on maven central (occasionally for pre-release builds that are milestones - though even though more likely the other numbers are sufficient)

@Shrinivas-Kane Shrinivas-Kane changed the title Bump think version to 1.7 Bump tink version to 1.7 Feb 2, 2023
@Shrinivas-Kane
Copy link
Author

yes, we should be able to consume 3.10.1

@planetf1 planetf1 merged commit 04f1fb2 into odpi:egeria-release-3.10 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants