Redesigned ConnectedAssetUniverse instantiation #7534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeVi3w
requested review from
planetf1,
pmarius22,
popa-raluca,
cmgrote,
lcpopa and
alexandra-bucur
as code owners
LeeVi3w
force-pushed
the
connected-asset-missing-props
branch
2 times, most recently
from
9f4e7ea
to
306ee83
Compare
Signed-off-by: Liviu Enache <[email protected]>
LeeVi3w
force-pushed
the
connected-asset-missing-props
branch
from
306ee83
to
65e569c
Compare
Signed-off-by: Liviu Enache <[email protected]>
LeeVi3w
force-pushed
the
connected-asset-missing-props
branch
from
65e569c
to
392985b
Compare
mandy-chessell
approved these changes
Mar 20, 2023
...dpi/openmetadata/frameworkservices/ocf/metadatamanagement/client/ConnectedAssetUniverse.java
Outdated
Show resolved
Hide resolved
...k/src/main/java/org/odpi/openmetadata/frameworks/connectors/properties/SchemaAttributes.java
Outdated
Show resolved
Hide resolved
...k/src/main/java/org/odpi/openmetadata/frameworks/connectors/properties/SchemaAttributes.java
Outdated
Show resolved
Hide resolved
...k/src/main/java/org/odpi/openmetadata/frameworks/connectors/properties/SchemaAttributes.java
Show resolved
Hide resolved
...work/src/main/java/org/odpi/openmetadata/frameworks/connectors/properties/AssetUniverse.java
Outdated
Show resolved
Hide resolved
...dpi/openmetadata/frameworkservices/ocf/metadatamanagement/client/ConnectedAssetUniverse.java
Outdated
Show resolved
Hide resolved
|
Need to correct the signing of your commits Click on the "DCO" details |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...metadata/frameworkservices/ocf/metadatamanagement/client/EgeriaConnectedAssetProperties.java
Fixed
Show fixed
Hide fixed
LeeVi3w
force-pushed
the
connected-asset-missing-props
branch
2 times, most recently
from
b90e6e7
to
6f2fe7d
Compare
Signed-off-by: Liviu Enache <[email protected]>
Signed-off-by: Liviu Enache <[email protected]>
Signed-off-by: Liviu Enache <[email protected]>
LeeVi3w
force-pushed
the
connected-asset-missing-props
branch
from
6f2fe7d
to
a004c18
Compare
mandy-chessell
approved these changes
Mar 21, 2023
Signed-off-by: Liviu Enache <[email protected]>
lpalashevski
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the instantiation method of
ConnectedAssetUniversefrom public constructors to static factory methods which return new objects.This change was made to allow the use of the
AssetUniversesuper constructor with parameters as to set the missing properties reported in issue #7505. This decision was taken due to the fact that the super constructor needed data which was retrieved after its call inside theConnectedAssetUniverseconstructor.The static factory methods introduced (one for each existing constructor) have the advantage of being able to process the needed data beforehand and then passing it to the
ConnectedAssetUniverse, which in turn can call the super constructor that populates the missing properties with the given data. The newly createdConnectedAssetUniverseobject is then returned.These static factory methods are called create, and they make use of only one (private)
ConnectedAssetUniverseconstructor which takes anAssetResponseobject and extracts theAssetbean containing the needed properties.I have chosen this approach to avoid having to separate the data gathering logic from the class itself and to avoid having to set the missing fields in a dedicated function when there already exists a super constructor that deals with this.
Related Issue(s)
#7505 [BUG] ConnectedAssetUniverse not gathering all asset properties
Testing
The testing has been manually done using an instance of ConnectedAssetClient inside a Java application.