Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy beans, swagger and javadoc #7654

Merged
merged 2 commits into from
May 7, 2023
Merged

Conversation

mandy-chessell
Copy link
Contributor

Description

This PR is removing serializable from many of the Asset Manager OMAS beans, simplifying the request bodies for Glossary Workflow OMVS and Glossary Browser OMVS.

There are additional queries support by Glossary Browser OMVS for retrieving related and classified elements.

Related Issue(s)

None

Testing

FVT

Release Notes & Documentation

All internal or part of the API

Additional notes

None

Signed-off-by: Mandy Chessell <[email protected]>
@mandy-chessell mandy-chessell merged commit b158848 into odpi:main May 7, 2023
* @throws PropertyServerException there is a problem instantiating the bean
*/
@SuppressWarnings(value = "unused")
public B getNewBean(Class<B> beanClass,

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [OpenMetadataAPIGenericConverter<B>.getNewBean](1); it is advisable to add an Override annotation.
* @throws PropertyServerException there is a problem instantiating the bean
*/
@SuppressWarnings(value = "unused")
public B getNewBean(Class<B> beanClass,

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [OpenMetadataAPIGenericConverter<B>.getNewBean](1); it is advisable to add an Override annotation.
EntityDetail primaryEntity,
String methodName) throws PropertyServerException
{
final String thisMethodName = "getNewBean(entity)";

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String thisMethodName' is never read.
*/
InstanceProperties instanceProperties = new InstanceProperties(primaryEntity.getProperties());

String typeName = primaryEntity.getType().getTypeDefName();

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String typeName' is never read.
Relationship relationship,
String methodName) throws PropertyServerException
{
final String thisMethodName = "getNewBean(entity, relationship)";

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String thisMethodName' is never read.
*/
InstanceProperties instanceProperties = new InstanceProperties(primaryEntity.getProperties());

String typeName = primaryEntity.getType().getTypeDefName();

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String typeName' is never read.
@@ -577,6 +572,7 @@
String createNoteLog(String userId,
String elementGUID,
NoteLogProperties noteLogProperties,
boolean isPublic,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'isPublic' is never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant