Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove certs & application.properties from main jar #7693

Merged
merged 5 commits into from
May 26, 2023

Conversation

mandy-chessell
Copy link
Contributor

Description

The purpose of this PR was to remove the application.properties, keystore.p12 and truststore.p12 from the main Egeria OMAGServerPlatform jar since it is causing problems for a production deployment of Egeria.

The knock on effects were:

  • the FVTs began to fail to start the platform because they started the platform in a build directory without the application.properties and certificate stores. Their gradle files have been updated to use a new test.applicaiton.properties files that correctly locates the certificate files when the FVT platforms are started.
  • The OMAGServerPlatform.java code has more debug messages - particularly around its startup environment.
  • The script that creates the certificates needed changing to ensure any newly created certificate files were copied to the right locations.

When testing the script that generates the truststore and keystore I discovered that MacOS users needed to install openssl. I updated the readme for the script with instructions to describe how to do this.

Related Issue(s)

Testing

Rebuilt egeria and proved the FVTs are running - also checked that the platform comes up when run from the assembly. Regenerated the certificates and ensured they are copied to the correct new locations.

Release Notes & Documentation

The documentation around our assembly and the build of the jar files needs significant improvement to explain where different parts of an installation (particularly when using the containers) comes from and what needs to be changed for a production deployment.

Additional notes

@mandy-chessell mandy-chessell merged commit 8e14c01 into odpi:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants