Add missing Javadoc to Asset Catalog and move it to Tech Preview #7723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandra Bucur <[email protected]>
lpalashevski
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Looks good, I approve with one remark related to the in-line comment I added for documenting all enums used for error/audit messages. I think we should add the value of the code in the javadoc text so it will show up in the html rendered docs. This makes it easier to read/troubleshoot using the docs - this is also done in other access services.
Lets make this change across all enums for consistency.
.../java/org/odpi/openmetadata/accessservices/assetcatalog/exception/AssetCatalogErrorCode.java
Outdated
Show resolved
Hide resolved
added 2 commits
June 21, 2023 09:31
Signed-off-by: Alexandra Bucur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added missing Javadoc for packages, classes, methods, enums, etc. Changed Asset Catalog OMAS status from In Development to Tech Preview.