Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to deployment #7724

Merged
merged 9 commits into from
Jun 9, 2023
Merged

Conversation

mandy-chessell
Copy link
Contributor

Description

Principally this PR aims to align the contents of the distribution to our documentation:

  • Adds a new folder called "platform" to the distribution which represents the platform. In this folder are:
    • The connector jar files (same as jars in server/lib)
    • A jar file called omag-server-platform-{release}.jar. This is a copy/rename of server/server-chassis-spring-{release}.jar
  • The server folder in the distribution is unchanged to allow time for people to migrate to the new jar file name.
  • The FVTs have been changed to run called omag-server-platform-{release}.jar

In addition

  • I fixed a bug in the getServerStatus REST API in platform services to return the status of inactive servers.
  • Many of the modules no longer have Serializable beans. This serialization is unnecessary. The only module that needs Serializable beans is the repository services.
  • I added a sample logback.xml for the platform that includes rolling logs.

Related Issue(s)

None

Testing

  • The FVTs work with either the server/server-chassis-spring-{release}.jar or omag-server-platform-{release}.jar
  • the labs work with omag-server-platform-{release}.jar

Release Notes & Documentation

There is a matching change needed to the docs to change the name of the Jar to use when starting up the platform. Also to remove the use of server-chassis except in the module description.

Additional notes

The impetus behind this change is that hte cloud native workgroup want to add a new runtime to support a single server. Therefore it is important for understandability to make sure our code artifacts distinguish between code that supports the platform and code that supports a server. The server-chassis naming is from a time before we added mulit-tenant support.

There is a follow-on PR to rename the server chassis modules to platform chassis

Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
@mandy-chessell mandy-chessell merged commit ea4e348 into odpi:main Jun 9, 2023
@planetf1
Copy link
Member

planetf1 commented Jun 9, 2023

At an appropriate time, for the current platform model, the egeria Dockerfile should be updated to use the new name/structure. The charts using the platform may not need changes, but should be checked.

@mandy-chessell
Copy link
Contributor Author

Thanks @planetf1, good point

@lpalashevski lpalashevski mentioned this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants