Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize configured topics for Access Services (OMASs) #7748

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

mandy-chessell
Copy link
Contributor

Description

Except when the "no-topics" option is specified, the access services configuration helper methods add a connection for both the InTopic and the OutTopic to each access service configuration irrespective of whether the particular OMAS supports these topics.

This has no impact at runtime because the OMASs simply do not start topics they do not use. However, from a set up point of view, it is misleading - and can result in an organization thinking they need to set up (and may be pay for) topics that are not use.

This PR adds knowledge of whether an OMAS supports the inTopic and/or OutTopic to AccessServiceDescription. This information is used by the configuration helper methods when setting up the access service configuration.

Related Issue(s)

None

Testing

Using the "Understanding server configuration" open metadata lab I checked that the configuration documents no longer contain unnecessary topic connections.

This is the list of topics for cocoMDS1 after the change:

List of Topics used by cocoMDS1
  egeria.omag.server.cocoMDS1.omas.assetcatalog.outTopic
  egeria.omag.server.cocoMDS1.omas.assetconsumer.outTopic
  egeria.omag.server.cocoMDS1.omas.assetmanager.outTopic
  egeria.omag.server.cocoMDS1.omas.assetowner.outTopic
  egeria.omag.server.cocoMDS1.omas.communityprofile.outTopic
  egeria.omag.server.cocoMDS1.omas.dataengine.inTopic
  egeria.omag.server.cocoMDS1.omas.datamanager.outTopic
  egeria.omag.server.cocoMDS1.omas.digitalarchitecture.outTopic
  egeria.omag.server.cocoMDS1.omas.governanceengine.outTopic
  egeria.omag.server.cocoMDS1.omas.assetlineage.outTopic

Notice Data Engine OMAS supports an InTopic only. All of the others support just an OutTopic. Prior to this change, each OMAS had both an InTopic and an OutTopic configured.

Release Notes & Documentation

The description from this PR is summarized in the R4.2 release notes.

Signed-off-by: Mandy Chessell <[email protected]>
@mandy-chessell mandy-chessell merged commit dbf1c02 into odpi:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant