Add valid values for files plus various code recator and fixes #7977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary purpose of this PR was to add support for reference data related to files. When files are being catalogued, the reference data helps to ensure the file uses the correct asset type, deployedImplementationType and fileType, since file names and file extensions are not always a reliable guide on their own. This process improves the findability of files by matching file names and file extensions.
This reference data is loaded via the OpenMetadataArchives.omarchive open metadata archive file.
This feature required updates to the valid values (reference data) support:
There are also updates to the integration connector provider to allow the developer to identify the deployed implementation type of the asset/capability that it works with. This helps to match available integration services with particular metadata elements. The deployed implementation type can be set on a CatalogTarget relationship as well.
The Open Integration Framwork (OIF) was not able to send audit log events because the severities for audit events were owned by the repository services which sit above the frameworks. I have moved the severities to the audit log framwroke and this has allows the integration services, and most of the view services/engine service to remove their dependency on the repository services.
In testing this feature, I uncovered and fixed a number of issues:
There are also numerous fixes to Javadoc to help to reduce the build warnings.
Related Issue(s)
None
Testing
The FVTs have been used to ensure there are no regressions.
The sample metadata server configurations in the omag-server-platform distribution will load the OpenMetadataArchives.omarchive file so this reference data is available for people new to the platform
Using these configuration and postman, I was able to verify that the reference data was present and correctly linked.
Release Notes & Documentation
Updates to the documentation are being merged in parallel
Additional notes
Next steps are to update the integration connectors to correctly identify their deployed implementation type.
The file cataloguing integration connectors need to be updated to make use of this new metadata.