Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid values for files plus various code recator and fixes #7977

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

mandy-chessell
Copy link
Contributor

Description

The primary purpose of this PR was to add support for reference data related to files. When files are being catalogued, the reference data helps to ensure the file uses the correct asset type, deployedImplementationType and fileType, since file names and file extensions are not always a reliable guide on their own. This process improves the findability of files by matching file names and file extensions.

This reference data is loaded via the OpenMetadataArchives.omarchive open metadata archive file.

This feature required updates to the valid values (reference data) support:

  • new properties for a valid value: isCaseSensitive and category
  • new relationships between valid values: ConsistentValidValues and ValidValueAssociation

There are also updates to the integration connector provider to allow the developer to identify the deployed implementation type of the asset/capability that it works with. This helps to match available integration services with particular metadata elements. The deployed implementation type can be set on a CatalogTarget relationship as well.

The Open Integration Framwork (OIF) was not able to send audit log events because the severities for audit events were owned by the repository services which sit above the frameworks. I have moved the severities to the audit log framwroke and this has allows the integration services, and most of the view services/engine service to remove their dependency on the repository services.

In testing this feature, I uncovered and fixed a number of issues:

  • the configuration document store connector was not being set up properly using the application.properties file
  • The repository services was sending events from the local repository before the access services were started. This meant the access services missed some of the events from an archive that is loaded at startup.

There are also numerous fixes to Javadoc to help to reduce the build warnings.

Related Issue(s)

None

Testing

The FVTs have been used to ensure there are no regressions.
The sample metadata server configurations in the omag-server-platform distribution will load the OpenMetadataArchives.omarchive file so this reference data is available for people new to the platform
Using these configuration and postman, I was able to verify that the reference data was present and correctly linked.

Release Notes & Documentation

Updates to the documentation are being merged in parallel

Additional notes

Next steps are to update the integration connectors to correctly identify their deployed implementation type.
The file cataloguing integration connectors need to be updated to make use of this new metadata.

Signed-off-by: Mandy Chessell <[email protected]>
@mandy-chessell mandy-chessell merged commit 00e191a into odpi:main Dec 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant