Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve view service admin and add sample view server #8009

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

mandy-chessell
Copy link
Contributor

Description

This PR updates the view services administration calls:

  • It updates the server-side request body used when configuring a view service to be ViewServiceRequestBody rather than ViewServiceConfig. There are three reasons for this change:
    • It matches the code in the admin services client
    • It makes the style of configuing the view services consistent with configuring the other registered services - ie access services, engine services and integration services.
    • The ViewServiceConfig structure includes many details that are filled in by the platform - and should not be supplied by the caller.
  • The ViewServiceRequestBody has been updated to optionally take a list of resource endpoints.
  • The "configure all view services" request has been restored. This configures all registered view services, passing the supplied request endpoints and view service options to all view services. If the view service does not use resource endpoints, it ignores them.

In addition, there are further improvements in administration:

  • The connector configuration factory only adds the connectorProviderClassName to connector types that are generated for a server's configuration document. This reduces the size of, for example, a metadata access store's configuration document by about a third, just because of the smaller Kafka connection object.
  • It is possible to add a default configuration document to the application.properties file to say, preconfigure the event bus defaults for all new servers.

There are two new sample server configurations in the omag-server-platform distribution: one for a view server and te other for an engine host. The existing simple-metadata-store, active-metadata-store and integration-daemon server configurations have be recreated to benefit from the more slim-line connector types.

Related Issue(s)

None

Testing

FVTs plus testing using the new sample server configurations

Release Notes & Documentation

This is the updated documentation for configuring the view services:

This is the description of the new properties for the application.properties file:

Additional notes

None

@mandy-chessell mandy-chessell merged commit 02dc41a into odpi:main Jan 23, 2024
4 checks passed
Comment on lines +162 to +166
VoidResponse restResult = restClient.callVoidPostRESTCall(methodName,
serverPlatformRootURL + urlTemplate,
viewServices,
adminUserId,
serverName);

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'VoidResponse restResult' is never read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant