Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add placholder support and survey reports #8016

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Add placholder support and survey reports #8016

merged 2 commits into from
Jan 30, 2024

Conversation

mandy-chessell
Copy link
Contributor

Description

This PR allows placeholder labels to be added to OMAG server configuration documents. For example:

eventBusConfig": 
        {
            "class": "EventBusConfig",
            "topicURLRoot": "egeria.omag",
            "configurationProperties":
             {
                "producer": {"bootstrap.servers": "{{kafkaep}}"},
                "consumer": {"bootstrap.servers": "{{kafkaep}}"}
             }
        }

The placeholder values are supplied in application.properties.

platform.placeholder.variables=\
  {\
    "kafkaep" : "localhost:9092"\
  }

The placeholder labels are replaced with the placholder values at server startup.

There is also an improved survey report.

Related Issue(s)

None

Testing

The sample configuration active-metadata-store uses the {{kafkaep}} placeholder variable.
A default is set up with the value localhost:9092 in applicaiton.properties

Release Notes & Documentation

This is a new function for the admin guide - updates in progress.

Additional notes

None

@mandy-chessell mandy-chessell merged commit f77c621 into odpi:main Jan 30, 2024
4 checks passed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 30, 2024
View reviewed changes
...c/main/java/org/odpi/openmetadata/engineservices/assetanalysis/admin/AssetAnalysisAdmin.java

/*
* Create an entry in the governance engine map for each configured engine.
*/
governanceEngineMap.setGovernanceEngineProperties(discoveryEngines,
governanceEngineMap.setGovernanceEngineProperties(engineServiceConfig.getEngines(),

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EngineServiceConfig.getEngines
Loading
should be avoided because it has been deprecated.
.../java/org/odpi/openmetadata/engineservices/governanceaction/admin/GovernanceActionAdmin.java

/*
* Create an entry in the governance engine map for each configured engine.
*/
governanceEngineMap.setGovernanceEngineProperties(governanceActionEngines,
governanceEngineMap.setGovernanceEngineProperties(engineServiceConfig.getEngines(),

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EngineServiceConfig.getEngines
Loading
should be avoided because it has been deprecated.
...g/odpi/openmetadata/engineservices/repositorygovernance/admin/RepositoryGovernanceAdmin.java

/*
* Create an entry in the governance engine map for each configured engine.
*/
governanceEngineMap.setGovernanceEngineProperties(engineConfigs,
governanceEngineMap.setGovernanceEngineProperties(engineServiceConfig.getEngines(),

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EngineServiceConfig.getEngines
Loading
should be avoided because it has been deprecated.
...src/main/java/org/odpi/openmetadata/engineservices/surveyaction/admin/SurveyActionAdmin.java

/*
* Create an entry in the governance engine map for each configured engine.
*/
governanceEngineMap.setGovernanceEngineProperties(surveyActionEngines,
governanceEngineMap.setGovernanceEngineProperties(engineServiceConfig.getEngines(),

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EngineServiceConfig.getEngines
Loading
should be avoided because it has been deprecated.
...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java
Date effectiveTime) throws InvalidParameterException,
UserNotAuthorizedException,
PropertyServerException
public void deleteRelatedElementsInStore(String relationshipGUID) throws InvalidParameterException,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
OpenMetadataStore.deleteRelatedElementsInStore
Loading
; it is advisable to add an Override annotation.
...k/src/main/java/org/odpi/openmetadata/frameworks/integration/context/OpenMetadataAccess.java
Date effectiveTime) throws InvalidParameterException,
UserNotAuthorizedException,
PropertyServerException
public void deleteMetadataElementInStore(String metadataElementGUID) throws InvalidParameterException,

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
OpenMetadataStore.deleteMetadataElementInStore
Loading
; it is advisable to add an Override annotation.
...g/odpi/openmetadata/accessservices/assetowner/client/converters/AssetOwnerConverterBase.java
{
RelatedElement relatedElement = new RelatedElement();

relatedElement.setRelationshipHeader(this.getMetadataElementHeader(beanClass, relationship, relationship.getRelationshipGUID(), null, methodName));

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
relationship
Loading
may be null at this access as suggested by
this
Loading
null guard.
...g/odpi/openmetadata/accessservices/assetowner/client/converters/AssetOwnerConverterBase.java
{
RelatedElement relatedElement = new RelatedElement();

relatedElement.setRelationshipHeader(this.getMetadataElementHeader(beanClass, relatedMetadataElement, relatedMetadataElement.getRelationshipGUID(), null, methodName));

Check warning

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
relatedMetadataElement
Loading
may be null at this access as suggested by
this
Loading
null guard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planetf1 planetf1 Awaiting requested review from planetf1

@bogdan-sava bogdan-sava Awaiting requested review from bogdan-sava bogdan-sava is a code owner

@lpalashevski lpalashevski Awaiting requested review from lpalashevski lpalashevski is a code owner

@davidradl davidradl Awaiting requested review from davidradl

@lcpopa lcpopa Awaiting requested review from lcpopa

@pmarius22 pmarius22 Awaiting requested review from pmarius22

@popa-raluca popa-raluca Awaiting requested review from popa-raluca

@alexandra-bucur alexandra-bucur Awaiting requested review from alexandra-bucur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mandy-chessell