Add Governance Server OMAS #8042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <[email protected]>
Signed-off-by: Mandy Chessell <[email protected]>
mandy-chessell
requested review from
alexandra-bucur,
lcpopa,
pmarius22,
popa-raluca and
cmgrote
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| String governanceRequestType, | ||
| String serviceRequestType, | ||
| Map<String, String> defaultAnalysisParameters, | ||
| List<String> serviceSupportedZones) throws InvalidParameterException, |
Check notice
Code scanning / CodeQL
Useless parameter Note
| String qualifiedName, | ||
| String displayName, | ||
| String description, | ||
| List<String> serviceSupportedZones) throws InvalidParameterException, |
Check notice
Code scanning / CodeQL
Useless parameter Note
Comment on lines
+117
to
+118
| "This is part of the normal shutdown of the service. No action is required if this is service" + | ||
| "shutdown was intentional."), |
Check notice
Code scanning / CodeQL
Missing space in string literal Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a new service called Governance Server OMAS responsible for supplying the Integration Daemon and Engine Host with configuration.
The Governance Engine OMAS now supplied REST APIs and Watchdog events to running Governance Action Services. This is the split of responsibility between the two services:
Related Issue(s)
There is also a fix to the Governance Browser OMVS where some parameters were reversed on the findGlossaryTerms and findGlossaryCategories methods.
Testing
Basic regression testing on the configuration sharing.
Release Notes & Documentation
Associated PR in progress.
Additional notes