Improve query performance and templating #8046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mandy Chessell <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1194,6 +1199,9 @@ | |||
| properties = archiveHelper.addStringMapPropertyToInstance(archiveRootName, properties, OpenMetadataProperty.ADDITIONAL_PROPERTIES.name, additionalProperties, methodName); | |||
| properties = archiveHelper.addPropertyMapToInstance(archiveRootName, properties, extendedProperties, methodName); | |||
|
|
|||
| List<Classification> classifications = new ArrayList<>(); | |||
Check failure
Code scanning / CodeQL
Container contents are never accessed Error
| * @param summary name for the enum | ||
| * @param description description of the use of this value | ||
| * @param abbreviation optional abbreviation | ||
| * @param url optional url for the term |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has 2 features in it:
- updating the generic handlers to pushdown limitByStatus and required classifications on query requests to the repository
- to only validate a specific anchor guid once on a query, rather than for each returned element.
Related Issue(s)
None
Testing
Testing through pushing queries through the GAF Opem Metadata Store
Release Notes & Documentation
None - the templating support is already documented and the performance improvements are internal
Additional notes