Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove open-discovery-services jar #8050

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

mandy-chessell
Copy link
Contributor

@mandy-chessell mandy-chessell commented Feb 21, 2024

Description

This PR reimplements the Atlas Discovery Service into an Atlas Survey Service. This was the last discovery service in the open-discovery-services.jar and so it has been removed.

All of the Atlas connectors are now gathered together in a separate jar called apache-atlas-connectors with is available through the distributions. The thought is that all of the connectors are likely to be used together or not at all so it was better to have them in one place rather than distributed across different jar files.

Related Issue(s)

There have been some bug fixes made while testing this change:

  • the admin call to add an integration group to a configuration document had a bug in its upsert logic that was corrupting the list of integration groups in the configuration document.
  • The paging iterator in connectedAssetProperties was not updating its pointers correctly.

Testing

Specific scenario testing

Release Notes & Documentation

Updates to docs have already been merged.

Additional notes

There are only two discovery services left in the egeria.git build. They are Coco Pharmaceuticals samples needed for the labs. Once they are rewritten to survey action services, the deprecation of the ODF, Asset Analysis OMES and Discovery Engine OMAS is complete.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@mandy-chessell mandy-chessell merged commit eb6b91c into odpi:main Feb 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant