New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to engine host and new Automated Curation OMVS #8053

Merged

mandy-chessell merged 3 commits into odpi:main from mandy-chessell:oak2024

Feb 22, 2024

Contributor

mandy-chessell commented Feb 22, 2024

Description

For the engine host this PR:

adds a fix in its event listener to ensure it is able to pick up engine action events. Prior to this fix, the enhancement to add the Governance Server OMAS changed the inheritance structure of the events being processed by the Engine Host and the consequence was that the requests for engine actions were being mistaken for engine action refresh requests.
extends the configuraton refresh thread to do an intemittent scan for engine actions that have been missed, either due to an outage in the event bus or the engine hosts. If an Approved Engine Action is found, it attemts to claim and process it.

This also adds an initial implementation of the Automated Curation OMVS which is able to define Governance ACtion Types and Governance Action Processes as well and initiate them in the engine host.

Related Issue(s)

See above

Testing

Basic FVT

Release Notes & Documentation

No updates needed - the Automation Curaiton OMVS is already documented

Additional notes

mandy-chessell added 2 commits

February 22, 2024 12:46


          Enalbe engine host to receive engine actions (again)

d850972

Signed-off-by: Mandy Chessell <[email protected]>


          Add Automated Curation OMVS module

fdace30

Signed-off-by: Mandy Chessell <[email protected]>

mandy-chessell enabled auto-merge

February 22, 2024 12:55


          Merge branch 'main' into oak2024

cf3d2ae

mandy-chessell merged commit 6f5480f into odpi:main

4 checks passed

github-advanced-security bot found potential problems

View reviewed changes

...g/odpi/openmetadata/viewservices/automatedcuration/server/AutomatedCurationRESTServices.java

+                  @SuppressWarnings(value = "unused")
+                  public VoidResponse removeNextActionProcessStep(String          serverName,
+                                                                  String          actionLinkGUID,
+                                                                  NullRequestBody requestBody)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'requestBody' is never used.

...g/odpi/openmetadata/viewservices/automatedcuration/server/AutomatedCurationRESTServices.java

+                  @SuppressWarnings(value = "unused")
+                  public VoidResponse removeFirstProcessStep(String          serverName,
+                                                             String          processGUID,
+                                                             NullRequestBody requestBody)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'requestBody' is never used.

...g/odpi/openmetadata/viewservices/automatedcuration/server/AutomatedCurationRESTServices.java

+                  @SuppressWarnings(value = "unused")
+                  public VoidResponse removeGovernanceActionProcessStep(String          serverName,
+                                                                        String          processStepGUID,
+                                                                        NullRequestBody requestBody)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'requestBody' is never used.

...g/odpi/openmetadata/viewservices/automatedcuration/server/AutomatedCurationRESTServices.java

+                  @SuppressWarnings(value = "unused")
+                  public VoidResponse removeGovernanceActionProcess(String          serverName,
+                                                                    String          processGUID,
+                                                                    NullRequestBody requestBody)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'requestBody' is never used.

...g/odpi/openmetadata/viewservices/automatedcuration/server/AutomatedCurationRESTServices.java

+                  @SuppressWarnings(value = "unused")
+                  public VoidResponse withdrawGovernanceActionProcess(String          serverName,
+                                                                      String          processGUID,
+                                                                      NullRequestBody requestBody)

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'requestBody' is never used.

...va/org/odpi/openmetadata/viewservices/automatedcuration/ffdc/AutomatedCurationAuditCode.java

+                   * @param params array of parameters (all strings).  They are inserted into the message according to the numbering in the message text.
+                   * @return message definition object.
+                   */
+                  public AuditLogMessageDefinition getMessageDefinition(String ...params)

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

AuditLogMessageSet.getMessageDefinition

; it is advisable to add an Override annotation.

...va/org/odpi/openmetadata/viewservices/automatedcuration/ffdc/AutomatedCurationAuditCode.java

+                   *
+                   * @return message definition object.
+                   */
+                  public AuditLogMessageDefinition getMessageDefinition()

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

AuditLogMessageSet.getMessageDefinition

; it is advisable to add an Override annotation.

...g/odpi/openmetadata/viewservices/automatedcuration/server/AutomatedCurationRESTServices.java

+                                                                     NullRequestBody requestBody)
+                  {
+                      final String methodName = "publishGovernanceActionProcess";
+                      final String processGUIDParameterName = "processGUID";

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'String processGUIDParameterName' is never read.

...g/odpi/openmetadata/viewservices/automatedcuration/server/AutomatedCurationRESTServices.java

+                                                                      NullRequestBody requestBody)
+                  {
+                      final String methodName = "withdrawGovernanceActionProcess";
+                      final String processGUIDParameterName = "processGUID";

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'String processGUIDParameterName' is never read.

...g/odpi/openmetadata/viewservices/automatedcuration/server/AutomatedCurationRESTServices.java

+                                                                    NullRequestBody requestBody)
+                  {
+                      final String methodName = "removeGovernanceActionProcess";
+                      final String processGUIDParameterName = "processGUID";

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'String processGUIDParameterName' is never read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet