New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Valid Metadata OMVS type support #8153

Merged

mandy-chessell merged 3 commits into odpi:main from mandy-chessell:oak2024

Apr 24, 2024

Contributor

mandy-chessell commented Apr 24, 2024

Description

Add support to retrieve Open Metadata Types to the Valid Metadata OMVS

Related Issue(s)

None

Testing

FVT and manual tests

Release Notes & Documentation

Already done

Additional notes

None

mandy-chessell and others added 2 commits

April 24, 2024 16:16


          Add Valid Metadata OMVS type support

edf1c46

Signed-off-by: Mandy Chessell <[email protected]>


          Merge branch 'main' into oak2024

e503d19

mandy-chessell enabled auto-merge

April 24, 2024 15:31


          Add comments to type methods

9e72a1a

Signed-off-by: Mandy Chessell <[email protected]>

mandy-chessell merged commit d8a0ef3 into odpi:main

4 checks passed

github-advanced-security bot found potential problems

View reviewed changes

.../main/java/org/odpi/openmetadata/accessservices/digitalarchitecture/api/ManageTemplates.java

+                  void addTemplateClassification(String                                 userId,
+                                                 String                                 elementGUID,
+                                                 TemplateClassificationProperties       properties,
+                                                 Map<String, List<Map<String, String>>> specification) throws InvalidParameterException,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'specification' is never used.

...-framework/src/main/java/org/odpi/openmetadata/frameworks/openmetadata/enums/KeyPattern.java

                    */
-                  public int getOpenTypeOrdinal()
+                  public boolean isDefault()

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataEnum.isDefault

; it is advisable to add an Override annotation.

...-framework/src/main/java/org/odpi/openmetadata/frameworks/openmetadata/enums/KeyPattern.java

    
                   */

                  public String getDescription()

                  public  String getDescriptionGUID()

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataEnum.getDescriptionGUID

; it is advisable to add an Override annotation.

...-framework/src/main/java/org/odpi/openmetadata/frameworks/openmetadata/enums/KeyPattern.java

+                   *
+                   * @return String description
+                   */
+                  public String getDescription() { return description; }

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataEnum.getDescription

; it is advisable to add an Override annotation.

...-framework/src/main/java/org/odpi/openmetadata/frameworks/openmetadata/enums/KeyPattern.java

-                  {
-                      return name;
-                  }
+                  public String getName() { return name; }

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataEnum.getName

; it is advisable to add an Override annotation.

...-framework/src/main/java/org/odpi/openmetadata/frameworks/openmetadata/enums/KeyPattern.java

-                  {
-                      return ordinal;
-                  }
+                  public int getOrdinal() { return ordinal; }

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataEnum.getOrdinal

; it is advisable to add an Override annotation.

...-framework/src/main/java/org/odpi/openmetadata/frameworks/openmetadata/enums/StarRating.java

                    */
-                  public int getOpenTypeOrdinal()
+                  public boolean isDefault()

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataEnum.isDefault

; it is advisable to add an Override annotation.

...-framework/src/main/java/org/odpi/openmetadata/frameworks/openmetadata/enums/StarRating.java

    
                   */

                  public String getDescription()

                  public  String getDescriptionGUID()

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataEnum.getDescriptionGUID

; it is advisable to add an Override annotation.

...-framework/src/main/java/org/odpi/openmetadata/frameworks/openmetadata/enums/StarRating.java

+                   *
+                   * @return String description
+                   */
+                  public String getDescription() { return description; }

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataEnum.getDescription

; it is advisable to add an Override annotation.

...-framework/src/main/java/org/odpi/openmetadata/frameworks/openmetadata/enums/StarRating.java

-                  {
-                      return name;
-                  }
+                  public String getName() { return name; }

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides

OpenMetadataEnum.getName

; it is advisable to add an Override annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet