Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup: TLS custom CA certs #1

Merged
merged 1 commit into from
Apr 1, 2023
Merged

fixup: TLS custom CA certs #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/OpenFeature.Contrib.Providers.Flagd/FlagdProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,14 +400,24 @@ private static Service.ServiceClient buildClientForPlatform(Uri url)
#else
var handler = new HttpClientHandler();
#endif
if (flagdCertPath != "")
{
if (!File.Exists(flagdCertPath))
{
return null;
if (flagdCertPath != "") {
#if NET5_0_OR_GREATER
if (File.Exists(flagdCertPath)) {
certificate = new X509Certificate2(flagdCertPath);
handler.ServerCertificateCustomValidationCallback = (message, cert, chain, _) => {
// the the custom cert to the chain, Build returns a bool if valid.
chain.ChainPolicy.TrustMode = X509ChainTrustMode.CustomRootTrust;
chain.ChainPolicy.CustomTrustStore.Add(certificate);
return chain.Build(cert);
};
} else {
throw new ArgumentException("Specified certificate cannot be found.");
}
certificate = new X509Certificate2(flagdCertPath);
handler.ClientCertificates.Add(certificate);
#else
// Pre-NET5.0 APIs for custom CA validation are cumbersome.
// Looking for additional contributions here.
throw new ArgumentException("Custom certificate authorities not supported on this platform.");
#endif
}
return new Service.ServiceClient(GrpcChannel.ForAddress(url, new GrpcChannelOptions
{
Expand Down