Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a moving boundary condenser for improved part load modeling #515

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented May 26, 2024

Especially in heat pump or refrigeration machine applications, the condenser component may have a significant heat transfer share from the desuperheating of the working fluid. The heat transfer coefficients for desuperheating and condensation usually differ strongly, therefore using an overall kA (UA) value for the complete process to model part load may not be correct. Therefore an approach is implemented with a moving boundary, which will split the virtual area of the condenser into a desuperheating and a condensation part. The split will happen proportionally to the heat transfer of each subprocess and be validated using reference data.

@pep8speaks
Copy link

pep8speaks commented May 26, 2024

Hello @fwitte! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 38:80: E501 line too long (83 > 79 characters)
Line 52:80: E501 line too long (80 > 79 characters)
Line 75:80: E501 line too long (87 > 79 characters)
Line 77:80: E501 line too long (84 > 79 characters)
Line 162:80: E501 line too long (92 > 79 characters)
Line 214:80: E501 line too long (88 > 79 characters)
Line 215:80: E501 line too long (92 > 79 characters)
Line 268:24: E222 multiple spaces after operator
Line 329:80: E501 line too long (92 > 79 characters)
Line 330:80: E501 line too long (96 > 79 characters)
Line 343:80: E501 line too long (84 > 79 characters)

Line 1:80: E501 line too long (93 > 79 characters)
Line 92:1: E402 module level import not at top of file
Line 103:80: E501 line too long (82 > 79 characters)
Line 104:80: E501 line too long (81 > 79 characters)
Line 150:80: E501 line too long (82 > 79 characters)
Line 151:80: E501 line too long (81 > 79 characters)
Line 160:32: W292 no newline at end of file

Comment last updated at 2024-08-06 15:26:04 UTC

fwitte added 12 commits May 26, 2024 22:18
The `MovingBoundaryHeatExchanger` is the more generic version of
the first implementation. It allows for any number of sections and
eventually will also be implemented for evaporation.

The main difference to the first draft of the
`MovingBoundaryCondenser` is, that it is nondimensional to U or A.
The sum of all UA values in the sections has to be equal to the UA
value originally calculated in the design phase. An adoption can
be made to this later, modifying the total UA value by lookup
tables similar to the ´kA_char´ approaches in the already existing
heat exchanger components.
… different sections for cold side temperature calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants