Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu text used as class names #37

Open
jimt opened this issue Mar 21, 2016 · 1 comment
Open

Menu text used as class names #37

jimt opened this issue Mar 21, 2016 · 1 comment
Labels
enhancement

Comments

@jimt
Copy link
Member

jimt commented Mar 21, 2016

Menu item text is turned into class names by lower casing and hyphenating with no prefixing/suffixing/escaping of existing class names. As an example a menu item of Course content turns into a menu item class course-content which has a CSS meaning. There are obviously many other names that would conflict with existing class names.
jimt added a commit that referenced this issue Mar 22, 2016
@jimt
Filter menu name out of menu classes.
4c29e21 
For reasons unknown, each word of the menu name appears as an
individual class in the list of classes associated with the
menu item. These were being concatenated together with hyphens,
but could end up with class names like 'course-content' which
has a special CSS meaning. For now we just filter out all
classes that don't contain a hyphen or underscore.

Workaround for #37
@jimt
Copy link
Member Author

jimt commented Mar 22, 2016

4c29e21 works around the problem. The proper solution would probably be to avoid the menu item title from appearing in the list of classes in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimt