Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow guests to use of arsenal limits dialog and set default guest limit to 0 #3234

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Apr 20, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

See #3230. Flipped the use of the arsenal limits dialog so that the default guest limit is 0 and commanders need to intentionally block removal of items from the arsenal. Enabled guest commanders to use the arsenal limits dialog to increase (but not decrease) limits, so that they can manage unlocking.

Please specify which Issue this PR Resolves.

closes #3230

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

IIRC the arsenal limits dialog doesn't work correctly in all resolutions and UI size settings, so I may need to sort that out if use of the dialog becomes more critical.

How can the changes be tested?

Make yourself a guest in localhost:

membersX = [];
membershipEnabled = true;

@jaj22 jaj22 added Change A change to existing functionality Draft labels Apr 20, 2024
@jaj22 jaj22 added this to the 3.6 milestone Apr 20, 2024
@ante185 ante185 requested a review from Tiny-DM April 20, 2024 22:24
@jaj22
Copy link
Author

jaj22 commented Apr 21, 2024

Added save & load of arsenal limits data. Should have been there ages ago.

Copy link

@ante185 ante185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm imo

@jaj22 jaj22 removed the Draft label Jun 5, 2024
@jaj22
Copy link
Author

jaj22 commented Jun 5, 2024

  • Ported arsenal limits dialog to Antistasi GUI style.
  • Changed logic to store last member-set value and constrain to that. Guests can now reduce guest-set values.

@ante185 Probably needs a second look.

@ante185
Copy link

ante185 commented Jun 5, 2024

Yep looks good still

@Bob-Murphy Bob-Murphy merged commit fb2bfba into official-antistasi-community:unstable Jun 8, 2024
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Change A change to existing functionality Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Change]: Start default arsenal limits at 0
3 participants