Skip to content

Commit

Permalink
Prioritize checks in movepicker
Browse files Browse the repository at this point in the history 
give a little bonus for moving pieces to squares where they give check

STC: https://tests.stockfishchess.org/tests/view/631da742162491686d2e40b5
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 80072 W: 21753 L: 21368 D: 36951
Ptnml(0-2): 421, 8876, 21075, 9225, 439

LTC: https://tests.stockfishchess.org/tests/view/631dd9e6b85daa436625de1d
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 263480 W: 70916 L: 70158 D: 122406
Ptnml(0-2): 322, 26156, 78029, 26908, 325

similar ideas have been tested by Viz and Guenther

closes #4165

bench: 4326572
  • Loading branch information
@vondele
mstembera authored and vondele committed Sep 17, 2022
1 parent 154e7af commit dc0c441
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/movepick.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ void MovePicker::score() {
: type_of(pos.moved_piece(m)) == ROOK && !(to_sq(m) & threatenedByMinor) ? 25000
: !(to_sq(m) & threatenedByPawn) ? 15000
: 0)
: 0);

: 0)
+ bool(pos.check_squares(type_of(pos.moved_piece(m))) & to_sq(m)) * 16384;
else // Type == EVASIONS
{
if (pos.capture(m))
Expand Down

4 comments on commit dc0c441

@atumanian
Copy link

@atumanian atumanian commented on dc0c441 Sep 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vizvezdenec
Thank you for approving my test. But why did you lower the throughput from 100 to 50? I'm at this moment running only one test, unlike you. Your 5 tests together are taking 500 cores, while my test only 30.

@Vizvezdenec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it's master vs master test and not an attempt for immediate elo gain, this tests are usually ran at 50% tp.

@atumanian
Copy link

@atumanian atumanian commented on dc0c441 Sep 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you think tests not for immediate elo gain are less important?
There are also SPSA tests, simplification SPRT tests - they don't immediately gain elo either and are usually run with 100 throughput.

@atumanian
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for posting this in the official repository. I wanted to post these comments in my own repository, but conflated them.

Please sign in to comment.