Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove late irreversible move extension #2836

Closed
wants to merge 2 commits into from
Closed

Remove late irreversible move extension #2836

wants to merge 2 commits into from

Conversation

unaiic
Copy link
Contributor

@unaiic unaiic commented Jul 26, 2020

STC https://tests.stockfishchess.org/tests/view/5f1c9669c09435d870cb9de9
LLR: 2.93 (-2.94,2.94) {-1.50,0.50}
Total: 38584 W: 7464 L: 7342 D: 23778
Ptnml(0-2): 581, 4328, 9365, 4424, 594

LTC https://tests.stockfishchess.org/tests/view/5f1d2e22c09435d870cb9e21
LLR: 2.94 (-2.94,2.94) {-1.50,0.50}
Total: 27840 W: 3417 L: 3353 D: 21070
Ptnml(0-2): 120, 2315, 8994, 2363, 128

bench: 4829418

Remove late irreversible move extension.

@unaiic
Copy link
Contributor Author

unaiic commented Jul 26, 2020

@vondele Why is it failing the tests? Everything seems to be fine.

@vondele
Copy link
Member

vondele commented Jul 26, 2020

your commit message doesn't contain a Bench: xxxxxx statement, only your pull request comment does.

@unaiic
Copy link
Contributor Author

unaiic commented Jul 26, 2020

Is it necessary to change it? If so, how can I change it?

@vondele
Copy link
Member

vondele commented Jul 26, 2020

you can git commit --amend your last commit, and force push the update git push origin +re5

bench: 4829418
@unaiic
Copy link
Contributor Author

unaiic commented Jul 26, 2020

Now it seems to have done the checks correctly :)

@unaiic unaiic changed the title Search tweak Remove late irreversible move extension Jul 26, 2020
@snicolet snicolet closed this in 62d3106 Jul 31, 2020
@snicolet snicolet added the to be merged Will be merged shortly label Jul 31, 2020
@snicolet
Copy link
Member

Merged via 62d3106, thanks!

@unaiic unaiic deleted the re5 branch August 9, 2020 14:01
noobpwnftw pushed a commit to noobpwnftw/Stockfish that referenced this pull request Aug 15, 2020
We simplify away the late irreversible move extension, which
does not seem to be necessary in the current master.

STC
LLR: 2.93 (-2.94,2.94) {-1.50,0.50}
Total: 38584 W: 7464 L: 7342 D: 23778
Ptnml(0-2): 581, 4328, 9365, 4424, 594
https://tests.stockfishchess.org/tests/view/5f1c9669c09435d870cb9de9

LTC
LLR: 2.94 (-2.94,2.94) {-1.50,0.50}
Total: 27840 W: 3417 L: 3353 D: 21070
Ptnml(0-2): 120, 2315, 8994, 2363, 128
https://tests.stockfishchess.org/tests/view/5f1d2e22c09435d870cb9e21

closes official-stockfish#2836

bench: 4829420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants