Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NNUE] Address single bench and PGO issues #2879

Closed

Conversation

mstembera
Copy link
Contributor

@mstembera mstembera commented Aug 1, 2020

  • Produce a single bench that depends on both Standard and NNUE evals
  • PGO builds now optimize both Standard and NNUE code paths

Separate benches are still available individually by
stockfish.exe bench 16 1 13 default depth classic
stockfish.exe bench 16 1 13 default depth NNUE
and remain unchanged as 4578298 and 3377227 respectively.

bench: 4471333 (with nn-c157e0a5755b.nnue present)
bench: 5196721 (without nn-c157e0a5755b.nnue present) This now fails due to new nnue-player-wip.

@mstembera mstembera changed the title Address single bench and PGO issues [NNUE] Address single bench and PGO issues Aug 1, 2020
@vondele
Copy link
Member

vondele commented Aug 1, 2020

I'll have a look at this a bit later, when some of the fishtest work has been done.

@mstembera
Copy link
Contributor Author

After rebasing the new nnue-player-wip master intentionally fails when there is no EvalFile present. This patch of course expects a nnue file and so the AppVeyor check fails. The default can be changed to classic but that defeats the purpose.

@mstembera
Copy link
Contributor Author

Closing since #2931

@mstembera mstembera closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants