Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic search to finished tests and rename URL parameters #1425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dav1312
Copy link
Contributor

@dav1312 dav1312 commented Sep 14, 2022

Add a basic search to finished tests and rename URL parameters
Also remove unused variables

Note: I'm not sure why we use 40 to search for LTC tests since we consider 20+0.2 with 8T as LTC

@ppigazzini
Copy link
Collaborator

DEV updated.

@vondele
Copy link
Member

vondele commented Oct 3, 2022

the 30 for LTC is a reasonable separator for sequential runs.. the 'issue' is that we should compute for threaded tests the 'effective' time namely TC * threads (so 8t * 5s/t = 40s should be sequential, while 8t * 20s/t = 160s is LTC).

@vondele
Copy link
Member

vondele commented Oct 3, 2022

In the longer term just differentiating STC / LTC by the time will be a bit difficult over the full period, i.e. if we change the definitions of STC and LTC.

Add a basic search to finished tests and rename URL parameters
Also remove unused variables
@ppigazzini
Copy link
Collaborator

DEV updated.

@dav1312
Copy link
Contributor Author

dav1312 commented Oct 4, 2022

Unsurprisingly, searching by info takes too long 😓

@dav1312
Copy link
Contributor Author

dav1312 commented Oct 5, 2022

Can we speed up pagination making something like this?
If the page_size is 25, search page_size + 1 elements (skipping if necessary) to see if there is a next page
This would not show the amount of available pages or return the total amount of elements but it would still allow pagination right?

@snicolet
Copy link
Member

snicolet commented Oct 5, 2022

Note that there is a google group forum with all the results of fishtest, letting the Google servers do the search for us may be faster: https://groups.google.com/g/fishcooking-results/search?q=antirazor

Of course some queries return several pages if the term happens to be in the title of a master commit (so we may need to parse the results): https://groups.google.com/g/fishcooking-results/search?q=simplify

@ppigazzini
Copy link
Collaborator

Can we speed up pagination making something like this? If the page_size is 25, search page_size + 1 elements (skipping if necessary) to see if there is a next page This would not show the amount of available pages or return the total amount of elements but it would still allow pagination right?

All the pages with pagination open very fast for me and in fishtest development we always check if the code is still working for the very old pages. Clicking 19270 times to get the last Events page is a no go for me :)

With master the navigation to a very old page is slow, but this is due to the skip() function.
https://www.mongodb.com/docs/manual/reference/method/cursor.skip/
https://www.codementor.io/@arpitbhayani/why-mongodb-s-cursor-skip-is-slow-90j5f3fst

BTW it seems that there are several approach to try to get a fast and consistent pagination, we can experiment with some of these.

@dav1312
Copy link
Contributor Author

dav1312 commented Oct 5, 2022

All the pages with pagination open very fast for me and in fishtest development we always check if the code is still working for the very old pages. Clicking 19270 times to get the last Events page is a no go for me :)

Ah sorry I meant speed up the search. Instead of trying to find all documents that match an info search, it would only need to find 26 right?

Clicking 19270 times to get the last Events page is a no go for me :)

Yeah It would suck but idk I'm not sure if adding even more indexes is fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement gui server server side changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants