-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic search to finished tests and rename URL parameters #1425
base: master
Are you sure you want to change the base?
Conversation
3e3cd00
to
48ce923
Compare
DEV updated. |
the 30 for LTC is a reasonable separator for sequential runs.. the 'issue' is that we should compute for threaded tests the 'effective' time namely TC * threads (so 8t * 5s/t = 40s should be sequential, while 8t * 20s/t = 160s is LTC). |
In the longer term just differentiating STC / LTC by the time will be a bit difficult over the full period, i.e. if we change the definitions of STC and LTC. |
Add a basic search to finished tests and rename URL parameters Also remove unused variables
DEV updated. |
Unsurprisingly, searching by info takes too long 😓 |
Can we speed up pagination making something like this? |
Note that there is a google group forum with all the results of fishtest, letting the Google servers do the search for us may be faster: https://groups.google.com/g/fishcooking-results/search?q=antirazor Of course some queries return several pages if the term happens to be in the title of a master commit (so we may need to parse the results): https://groups.google.com/g/fishcooking-results/search?q=simplify |
All the pages with pagination open very fast for me and in fishtest development we always check if the code is still working for the very old pages. Clicking 19270 times to get the last Events page is a no go for me :) With master the navigation to a very old page is slow, but this is due to the BTW it seems that there are several approach to try to get a fast and consistent pagination, we can experiment with some of these. |
Ah sorry I meant speed up the search. Instead of trying to find all documents that match an info search, it would only need to find 26 right?
Yeah It would suck but idk I'm not sure if adding even more indexes is fine... |
Add a basic search to finished tests and rename URL parameters
Also remove unused variables
Note: I'm not sure why we use 40 to search for LTC tests since we consider 20+0.2 with 8T as LTC