MAINT: fix gdr_unpin_buffer warning #10037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add |
* Fix the warning message when `gdr_unpin_buffer` fails, so that the message is not conflated with the prior `gdr_unmap` call. Signed-off-by: Tyler Reddy <[email protected]>
tylerjereddy
force-pushed
the
treddy_fix_gdrcopy_err
branch
from
d717f82
to
5524e7e
Compare
|
done (not sure if you have |
j-xiong
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gdr_unpin_bufferfails, so that the message is not conflated withthe prior
gdr_unmapcall.I believe there may be deeper issues in the code here per NVIDIA/gdrcopy#296 (comment), but just cleaning this up to start.