Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): change analytics permissions name #132

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat(cli): change analytics permissions name #132

merged 1 commit into from
Sep 10, 2024

Conversation

alewin
Copy link

@alewin alewin commented Sep 9, 2024

Ticket:

Description

Rename the Matomo permission website to measurable to avoid naming-conflict with the upcoming analytics:website permission, which will refer to the Analytics API feature.

Type

  • Dependency upgrade
  • Bug fix
  • New feature
  • Dev change

Checklist:

  • I have added tests that prove my fix is effective or that my feature works

Screenshots:

N/A

@alewin alewin self-assigned this Sep 9, 2024
andreacappadona17
andreacappadona17 approved these changes Sep 9, 2024
View reviewed changes
Copy link

@andreacappadona17 andreacappadona17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alewin alewin merged commit 2103740 into dev Sep 10, 2024
4 checks passed
@alewin alewin deleted the fix/change-analytics-permission-names branch September 10, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreacappadona17 andreacappadona17 andreacappadona17 approved these changes

Assignees

@alewin alewin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alewin @andreacappadona17