-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add grafana observability to logto #136
base: dev
Are you sure you want to change the base?
Conversation
Hey @bozzelliandrea that looks great! Might I ask you just one change? At the moment, in order to track all the changes that we're doing (we don't want to diverge too much from the original repo), we're including a |
5abbd5c
to
4f1ab97
Compare
Hi @alfonsograziano , thanks for the feedback, I added some comments for the lines introduced with the feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just on a side note, next week we will have a pen test on Logto and we would like to NOT merge PRs (if not critical).
Would it be fine for you to keep this one opened and ready to be merged as soon as we complete the pen test?
It will be on the Staging env (so Dev shouldn't be affected), but still would be ideal to not introduce any change in the code for the moment being
Sure no problem, @alfonsograziano we merge after pen-test. |
Setting this PR to draft to avoid accidental merges. |
@bozzelliandrea |
4f1ab97
to
349ca5f
Compare
Ticket:
Description
With this PR we add grafana instrumentation for observability integration. The application will collect traces and metrics, for the logs, we use the manual publishing logger configuration
Type
Checklist:
Screenshots:
N/A