Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): fixed mygovid 00000 phone number #91

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(connector): fixed mygovid 00000 phone number #91

merged 1 commit into from
Jul 19, 2024

Conversation

SamSalvatico
Copy link
Collaborator

Description

If the phone number from MyGovId is +00000 or similar, we set it as undefined to avoid Logto linking users with same phone number

Type

  • Dependency upgrade
  • Bug fix
  • [] New feature
  • Dev change

@SamSalvatico SamSalvatico self-assigned this Jul 19, 2024
edge33
edge33 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@edge33 edge33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMAFAICT

@SamSalvatico SamSalvatico merged commit eff5f06 into dev Jul 19, 2024
1 of 4 checks passed
@SamSalvatico SamSalvatico deleted the fix/mygovid-phone-number branch July 19, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edge33 edge33 edge33 approved these changes

Assignees

@SamSalvatico SamSalvatico

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamSalvatico @edge33