Skip to content

fix: do not fold Set-Cookie values into a single header, per RFC6265 #1818

fix: do not fold Set-Cookie values into a single header, per RFC6265

fix: do not fold Set-Cookie values into a single header, per RFC6265 #1818

Re-run triggered September 6, 2023 07:31
Status Failure
Total duration 46s
Artifacts

commitlint.yml

on: pull_request
commitlint
32s
commitlint
Fit to window
Zoom out
Zoom in

Annotations

1 error
commitlint
You have commit messages with errors ⧗ input: fix: Do not fold Set-Cookie values into single header This commit adds a special case for encoding Set-Cookie headers in responses. Specifically, it prevents `headerParamEncoder` from folding multiple header values into a single header value with a comma separator, as per RFC6265: Origin servers SHOULD NOT fold multiple Set-Cookie header fields into a single header field. The usual mechanism for folding HTTP headers fields (i.e., as defined in [RFC2616]) might change the semantics of the Set-Cookie header field because the %x2C (",") character is used by Set-Cookie in a way that conflicts with such folding. The comma mentioned by the RFC appears when using a cookie with an expiry timestamp, because the timestamp format uses a comma after the day-of-week. ✖ subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint