Merge pull request #1016 from tdakkota/fix/fix-g601

fix: linter memory aliasing issue

gen/generator.go

@@ -219,7 +219,7 @@ func (g *Generator) makeWebhooks(webhooks []openapi.Webhook) error {
 				continue
 			}
 
-			xslices.Filter(&spec.Parameters, func(p *openapi.Parameter) bool {
+			spec.Parameters = xslices.Filter(spec.Parameters, func(p *openapi.Parameter) bool {
 				if p.In.Path() {
 					log.Warn("Webhooks can't have path parameters",
 						zap.String("name", p.Name),

gen/schema_gen_sum.go

@@ -283,7 +283,7 @@ func (g *schemaGen) oneOf(name string, schema *jsonschema.Schema, side bool) (*i
 					})
 
 					// Filter discriminator field in-place.
-					xslices.Filter(&s.Fields, func(f *ir.Field) bool {
+					s.Fields = xslices.Filter(s.Fields, func(f *ir.Field) bool {
 						return f.Tag.JSON != propName
 					})
 

internal/xslices/xslices.go

@@ -4,18 +4,16 @@ package xslices
 import "golang.org/x/exp/slices"
 
 // Filter performs in-place filtering of a slice.
-func Filter[S ~[]E, E any](sptr *S, keep func(E) bool) {
-	var (
-		n int
-		s = *sptr
-	)
+func Filter[S ~[]E, E any](s S, keep func(E) bool) S {
+	var n int
 	for _, v := range s {
 		if keep(v) {
 			s[n] = v
 			n++
 		}
 	}
-	*sptr = s[:n]
+	s = s[:n]
+	return s
 }
 
 // FindFunc returns the first element satisfying the predicate.

internal/xslices/xslices_test.go

@@ -12,10 +12,7 @@ func TestFilter(t *testing.T) {
 	odd := func(x int) bool {
 		return x%2 == 1
 	}
-	filter := func(v []int, cb func(int) bool) []int {
-		Filter(&v, cb)
-		return v
-	}
+	filter := Filter[[]int]
 
 	a.Empty(filter([]int(nil), odd))
 	a.Empty(filter([]int{}, odd))

jsonschema/parser_enum.go

@@ -107,7 +107,7 @@ func handleNullableEnum(s *Schema) {
 	})
 	// Filter all `null`s.
 	if s.Nullable {
-		xslices.Filter(&s.Enum, func(v any) bool {
+		s.Enum = xslices.Filter(s.Enum, func(v any) bool {
 			return v != nil
 		})
 	}