Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oauth2): added support #1025

Merged
merged 1 commit into from
Sep 10, 2023
Merged

feat(oauth2): added support #1025

merged 1 commit into from
Sep 10, 2023

Conversation

alesbrelih
Copy link
Contributor

@alesbrelih alesbrelih commented Sep 5, 2023

Hi!

Thanks for this generation, after quite a search it seems like this generator actually works! And it has nice golang syntax behind it.

Because the only limitation I have with this generation is the lack of oauth2 security provider I decided I wanted to contribute to this project.

I wanted to implement it as simple as possible.

Thanks!

@alesbrelih alesbrelih force-pushed the feat/oauth2 branch 2 times, most recently from 86cd90d to ed8dbf8 Compare September 6, 2023 07:43
@alesbrelih alesbrelih changed the title feat(oauth2): temp add feat(oauth2): added support Sep 6, 2023
@alesbrelih alesbrelih force-pushed the feat/oauth2 branch 2 times, most recently from 39d70c7 to 66a87fc Compare September 6, 2023 08:22
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 96.66% and project coverage change: -0.03% ⚠️

Comparison is base (660d20e) 72.20% compared to head (f22ad07) 72.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   72.20%   72.18%   -0.03%     
==========================================
  Files         192      192              
  Lines       14991    15015      +24     
==========================================
+ Hits        10825    10838      +13     
- Misses       3631     3641      +10     
- Partials      535      536       +1     
Files Changed Coverage Δ
gen/gen_security.go 79.85% <96.29%> (-4.08%) ⬇️
gen/gen_operation.go 88.88% <100.00%> (ø)
gen/ir/security.go 84.61% <100.00%> (+1.28%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alesbrelih
Copy link
Contributor Author

Forgot to run lint task, now it should be fixed.

gen/_template/security.tmpl Outdated Show resolved Hide resolved
gen/_template/security.tmpl Show resolved Hide resolved
Added support for oauth2 security scheme.
Added petstore-oauth2.yml example that generates oauth2 security scheme.
@shadowspore
Copy link
Member

@tdakkota ptal

@tdakkota tdakkota merged commit 7e2c06a into ogen-go:main Sep 10, 2023
15 checks passed
@alesbrelih alesbrelih deleted the feat/oauth2 branch September 11, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants