Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow server variable enum to be unset #1273

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

atombender
Copy link
Contributor

Fixes #1272.

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.90%. Comparing base (4024c9f) to head (99f5080).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1273   +/-   ##
=======================================
  Coverage   73.90%   73.90%           
=======================================
  Files         189      189           
  Lines       12855    12855           
=======================================
  Hits         9501     9501           
  Misses       2805     2805           
  Partials      549      549           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tdakkota tdakkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, edit your commit to follow Conventional Commits. Commit linter is not happy about period at the end of commit message, I guess.

Everything else looks good to me. Thank you.

@atombender
Copy link
Contributor Author

@tdakkota Seems overly picky, but okay, done.

@tdakkota tdakkota enabled auto-merge July 1, 2024 12:05
@tdakkota tdakkota merged commit 68907b2 into ogen-go:main Jul 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Servers: Variables do not support non-enums
2 participants