Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use slices from standard library #1286

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

davidkuridza
Copy link
Contributor

I noticed golang.org/x/exp/slices was updated by Renovate in one of our pipelines. This PR removes the dependency in favor of the slices package from the standard library.

The same can be done withgolang.org/x/exp/maps by adding Keys() and Values() to xmaps. Please let me know if I should do that as well.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.92%. Comparing base (99f5080) to head (12fe015).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
+ Coverage   73.90%   73.92%   +0.01%     
==========================================
  Files         189      189              
  Lines       12855    12855              
==========================================
+ Hits         9501     9503       +2     
+ Misses       2805     2804       -1     
+ Partials      549      548       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdakkota tdakkota enabled auto-merge August 6, 2024 15:22
@tdakkota tdakkota merged commit ade620b into ogen-go:main Aug 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants