Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue 1327 during code generation #1328

Merged
merged 3 commits into from
Oct 16, 2024
Merged

fix: issue 1327 during code generation #1328

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f5c7fb
fix: issue 1327 during code generation
yawnak Oct 12, 2024
418f83c
refactor: improve fix using tdakkota suggestion
yawnak Oct 12, 2024
d6350da
Merge branch 'main' into fix-1327
yawnak Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gen/_template/json/encode.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ if {{ $.Var }}.Set {
{{/* Encode value that implements jx.Encoder with respect to nil semantic */}}
{{- define "json/enc_value" -}}
{{- $t := $.Type -}}
{{- if or ($t.NilSemantic.Invalid) ($t.NilSemantic.Optional) -}}
{{- if or ($t.NilSemantic.Invalid) ($t.NilSemantic.Optional) }}
if {{ $.Var }} != nil {
{{- template "json/enc_field" $ }}
{{ $.Var }}.Encode(e)
Expand Down
Loading