-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition in consultation creation #2299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainak
requested review from
rithviknishad,
khavinshankar,
shivankacker and
vigneshhari
July 9, 2024 14:14
rithviknishad
approved these changes
Jul 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2299 +/- ##
===========================================
+ Coverage 63.69% 63.77% +0.07%
===========================================
Files 238 239 +1
Lines 13384 13407 +23
Branches 1908 1908
===========================================
+ Hits 8525 8550 +25
+ Misses 4509 4508 -1
+ Partials 350 349 -1 ☔ View full report in Codecov by Sentry. |
sainak
force-pushed
the
sainak/fix/atomicity-of-consultations
branch
from
July 17, 2024 07:04
dbeb92d
to
2b13232
Compare
vigneshhari
requested changes
Aug 16, 2024
sainak
force-pushed
the
sainak/fix/atomicity-of-consultations
branch
from
August 19, 2024 15:34
cfea5ac
to
41bdfb3
Compare
vigneshhari
approved these changes
Aug 19, 2024
vigneshhari
approved these changes
Aug 19, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a race condition that allowed duplicate consultations to be created. The issue was caused by concurrent requests creating consultations for the same patient. The fix ensures that only one consultation is created for each patient, preventing duplicates.