-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy consultation bed #2506
base: develop
Are you sure you want to change the base?
Privacy consultation bed #2506
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2506 +/- ##
===========================================
+ Coverage 70.03% 70.06% +0.02%
===========================================
Files 198 199 +1
Lines 11674 11779 +105
Branches 1607 1626 +19
===========================================
+ Hits 8176 8253 +77
- Misses 3107 3132 +25
- Partials 391 394 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no TTL for a lock? Feels like if you forget to unlock, if the locked user forgets to unlock, the resource is just locked forever.
send_webpush(username=current_user, message=message) | ||
|
||
def lock_camera(self) -> bool: | ||
current_user = cache.get(self.current_user_cache_key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not how we implement locks in care, refer to other lock implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vigneshhari This implementation was based on the existing implementation of locks in discharge summary (https://github.com/ohcnetwork/care/blob/develop/care/facility/utils/reports/discharge_summary.py#L40)
Why are there no tests for this change? |
Associated Issue
@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins