Adding support for native Kubernetes executor #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR @KrKOo! We'll start reviewing it and hopefully get in approved for the release pipeline. 🚀 |
|
Apologies for the glacial pace with merging this issue — we just tested it locally and everything looks great, thank you for the contribution! Rebasing onto latest development branch now... |
✅ Deploy Preview for ohsu-comp-bio-funnel canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #748, running Docker-in-Docker for each job is not nearly as effective or secure as utilizing the Kubernetes API for the same purpose. This PR introduces optional native Kubernetes job execution.
How does it work:
When the worker is configured to use the Kubernetes executor, it initializes the environment in the same way as when using Docker. Then instead of running a Docker container, it creates another Kubernetes Job.
TODO: