Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/traverse maintenance #80

Merged
merged 5 commits into from
Apr 5, 2021
Merged

Conversation

okazy
Copy link
Owner

@okazy okazy commented Apr 2, 2021

概要(Overview・Refs Issue)

EC-CUBE#4966

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #80 (28bf606) into feature/41beta2 (3f08e3f) will decrease coverage by 0.21%.
The diff coverage is 29.41%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             feature/41beta2      #80      +/-   ##
=====================================================
- Coverage              76.38%   76.17%   -0.22%     
- Complexity              6190     6216      +26     
=====================================================
  Files                    445      448       +3     
  Lines                  20955    21051      +96     
=====================================================
+ Hits                   16006    16035      +29     
- Misses                  4949     5016      +67     
Flag Coverage Δ Complexity Δ
tests 76.17% <29.41%> (-0.22%) 0.00 <21.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...Controller/Admin/Content/MaintenanceController.php 0.00% <0.00%> (ø) 8.00 <0.00> (ø)
src/Eccube/Service/SystemService.php 30.30% <0.00%> (-4.32%) 28.00 <12.00> (+6.00) ⬇️
...Http/Authentication/EccubeLogoutSuccessHandler.php 37.50% <37.50%> (ø) 3.00 <3.00> (?)
src/Eccube/EventListener/MaintenanceListener.php 62.50% <62.50%> (ø) 6.00 <6.00> (?)
...rc/Eccube/EventListener/TwigInitializeListener.php 85.88% <100.00%> (+0.34%) 28.00 <0.00> (ø)
...be/Service/PurchaseFlow/Processor/TaxProcessor.php 79.62% <0.00%> (-3.71%) 21.00% <0.00%> (ø%)
.../Eccube/Controller/Admin/Order/OrderController.php 83.66% <0.00%> (-0.49%) 68.00% <0.00%> (ø%)
src/Eccube/Service/CartService.php 93.75% <0.00%> (-0.03%) 69.00% <0.00%> (ø%)
src/Eccube/Repository/MemberRepository.php 100.00% <0.00%> (ø) 8.00% <0.00%> (ø%)
src/Eccube/Form/Type/Admin/SearchProductType.php 100.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f08e3f...28bf606. Read the comment docs.

@okazy okazy merged commit e203454 into feature/41beta2 Apr 5, 2021
@okazy okazy deleted the feature/traverse-maintenance branch April 5, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants