Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1/seo #81

Merged
merged 3 commits into from
Apr 5, 2021
Merged

4.1/seo #81

merged 3 commits into from
Apr 5, 2021

Conversation

okazy
Copy link
Owner

@okazy okazy commented Apr 2, 2021

概要(Overview・Refs Issue)

EC-CUBE#4808

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

tao-s and others added 3 commits March 26, 2021 18:00
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (feature/41beta2@c46e77c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             feature/41beta2      #81   +/-   ##
==================================================
  Coverage                   ?   76.22%           
  Complexity                 ?     6199           
==================================================
  Files                      ?      446           
  Lines                      ?    21005           
  Branches                   ?        0           
==================================================
  Hits                       ?    16012           
  Misses                     ?     4993           
  Partials                   ?        0           
Flag Coverage Δ Complexity Δ
tests 76.22% <0.00%> (?) 0.00% <0.00%> (?%)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46e77c...9e78398. Read the comment docs.

@okazy okazy merged commit 57178d4 into feature/41beta2 Apr 5, 2021
@okazy okazy deleted the 4.1/seo branch April 5, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants