Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vSphere, UPI] I can read the ignition files from outside of the cluster without providing credentials #176

Closed
jomeier opened this issue May 13, 2020 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jomeier
Copy link
Contributor

jomeier commented May 13, 2020

Hi,

in my UPI vSphere setup I am able to get the ignition files for masters and workers with:

from my local PC which is NOT part of the cluster. In my opinion this shouldn't work without providing credentials.

Version: Beta4

The solution for that seems to be to install a firewall around the cluster. But this seems to be kind of a workaround.

I rshed into several pods on my cluster and tried this curl to check, if any user that can enter the terminal of a pod can curl the ignition files and maybe can read cloud provider secrets provided there. In this case I got a 'connection refused' message. A user seems not to be able to get the ignition file. But I feel uncomfortable if this works in all situations.

The ignition files shouldn't be available without protection of the REST API of the machine config daemon at all in my opinion.

Greetings,

Josef

@jomeier jomeier changed the title [vSphere, UPI] I can read the ignition files from outside of the cluster with curl [vSphere, UPI] I can read the ignition files from outside of the cluster without providing credentials May 13, 2020
@vrutkovs
Copy link
Member

Related: openshift/machine-config-operator#784

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2020
@vrutkovs
Copy link
Member

This resulted in openshift/enhancements#443

binnes pushed a commit to binnes/okd that referenced this issue Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants