refactor: Drop support for Node.js 4 #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## next #399 +/- ##
==========================================
- Coverage 98.22% 98.16% -0.06%
==========================================
Files 11 11
Lines 225 218 -7
Branches 24 24
==========================================
- Hits 221 214 -7
Misses 4 4
Continue to review full report at Codecov.
|
okonet
approved these changes
Feb 17, 2018
- Change Node.js requirement in `engines.node` to `>=6`. Use `please-upgrade-node` to give helpful error message on older versions. - Remove node 4 from list of Node.js versions to test on CI. Also remove `--ignore-engines` flag for `yarn install`, not required with node 6. - Add note to readme for Node.js version requirement. - Target node 6 for `babel-preset-env` (relevant only for tests). - Add eslint rule for `prefer-destructuring`, do relevant code changes. - Use default argument for `logger` passed to `src/index.js` BREAKING CHANGE: Requires Node.js v6 or later.
sudo-suhas
force-pushed
the
refactor/drop-node-4-support
branch
from
d976c69
to
9c9f7a8
Compare
sudo-suhas
added a commit
that referenced
this pull request
Feb 19, 2018
- Change Node.js requirement in `engines.node` to `>=6`. Use `please-upgrade-node` to give helpful error message on older versions. - Remove node 4 from list of Node.js versions to test on CI. Also remove `--ignore-engines` flag for `yarn install`, not required with node 6. - Add note to readme for Node.js version requirement. - Target node 6 for `babel-preset-env` (relevant only for tests). - Add eslint rule for `prefer-destructuring`, do relevant code changes. - Use default argument for `logger` passed to `src/index.js` BREAKING CHANGE: Requires Node.js v6 or later.
sudo-suhas
added a commit
that referenced
this pull request
Feb 21, 2018
- Change Node.js requirement in `engines.node` to `>=6`. Use `please-upgrade-node` to give helpful error message on older versions. - Remove node 4 from list of Node.js versions to test on CI. Also remove `--ignore-engines` flag for `yarn install`, not required with node 6. - Add note to readme for Node.js version requirement. - Target node 6 for `babel-preset-env` (relevant only for tests). - Add eslint rule for `prefer-destructuring`, do relevant code changes. - Use default argument for `logger` passed to `src/index.js` BREAKING CHANGE: Requires Node.js v6 or later.
This was referenced Feb 21, 2018
This was referenced Mar 15, 2018
This was referenced Apr 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the minimum required Node.js version to
>=6and does the relevant config, code and docs update.Code Changelog
engines.nodeto>=6. Useplease-upgrade-nodeto give helpful error message on older versions.--ignore-enginesflag foryarn install, not required with node 6.babel-preset-env(relevant only for tests).prefer-destructuring, do relevant code changes.loggerpassed tosrc/index.jsCloses #372.