Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] LoRA default alpha #104

Merged
merged 1 commit into from
Dec 2, 2023
Merged

[Fix] LoRA default alpha #104

merged 1 commit into from
Dec 2, 2023

Conversation

okotaku
Copy link
Owner

@okotaku okotaku commented Dec 2, 2023

Motivation

I had a wrong understanding of the relationship between alpha and scaling in peft and have corrected it. alpha must be the same value as r in order to match diffusers.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

📚 Documentation preview 📚: https://DiffEngine--104.org.readthedocs.build/en/104/

@okotaku okotaku self-assigned this Dec 2, 2023
@okotaku okotaku merged commit 7c05379 into main Dec 2, 2023
3 checks passed
@okotaku okotaku deleted the fix/default_alpha branch December 2, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant